Skip to content

Commit aed1e81

Browse files
author
Alex Menkov
committed
8317285: Misspellings in hprof test lib
Reviewed-by: sspitsyn, cjplummer
1 parent 741ae06 commit aed1e81

File tree

4 files changed

+50
-50
lines changed

4 files changed

+50
-50
lines changed

test/hotspot/jtreg/serviceability/jvmti/vthread/HeapDump/VThreadInHeapDump.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ private static void verifyDump(File dumpFile) throws Exception {
261261
private static List<Root> findStackRoot(List<Root> roots, ThreadObject thread) {
262262
List<Root> result = new ArrayList<>();
263263
for (Root root: roots) {
264-
if (root.getRefererId() == thread.getId()) {
264+
if (root.getReferrerId() == thread.getId()) {
265265
result.add(root);
266266
}
267267
}
@@ -286,7 +286,7 @@ private static void test(Snapshot snapshot, String className) {
286286
throw new RuntimeException("No root for " + className + " instance");
287287
}
288288
log(" root: " + root.getDescription());
289-
JavaHeapObject referrer = root.getReferer();
289+
JavaHeapObject referrer = root.getReferrer();
290290
log(" referrer: " + referrer);
291291
}
292292

test/lib/jdk/test/lib/hprof/model/JavaHeapObject.java

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 1997, 2023, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -53,13 +53,13 @@ public abstract class JavaHeapObject extends JavaThing {
5353
//
5454
// Who we refer to. This is heavily optimized for space, because it's
5555
// well worth trading a bit of speed for less swapping.
56-
// referers and referersLen go through two phases: Building and
57-
// resolved. When building, referers might have duplicates, but can
58-
// be appended to. When resolved, referers has no duplicates or
56+
// referrers and referrersLen go through two phases: Building and
57+
// resolved. When building, referrers might have duplicates, but can
58+
// be appended to. When resolved, referrers has no duplicates or
5959
// empty slots.
6060
//
61-
private JavaThing[] referers = null;
62-
private int referersLen = 0; // -1 when resolved
61+
private JavaThing[] referrers = null;
62+
private int referrersLen = 0; // -1 when resolved
6363

6464
public abstract JavaClass getClazz();
6565
public abstract long getSize();
@@ -77,25 +77,25 @@ public void resolve(Snapshot snapshot) {
7777
}
7878

7979
//
80-
// Eliminate duplicates from referers, and size the array exactly.
80+
// Eliminate duplicates from referrers, and size the array exactly.
8181
// This sets us up to answer queries. See the comments around the
82-
// referers data member for details.
82+
// referrers data member for details.
8383
//
84-
void setupReferers() {
85-
if (referersLen > 1) {
86-
// Copy referers to map, screening out duplicates
84+
void setupReferrers() {
85+
if (referrersLen > 1) {
86+
// Copy referrers to map, screening out duplicates
8787
Map<JavaThing, JavaThing> map = new HashMap<JavaThing, JavaThing>();
88-
for (int i = 0; i < referersLen; i++) {
89-
if (map.get(referers[i]) == null) {
90-
map.put(referers[i], referers[i]);
88+
for (int i = 0; i < referrersLen; i++) {
89+
if (map.get(referrers[i]) == null) {
90+
map.put(referrers[i], referrers[i]);
9191
}
9292
}
9393

9494
// Now copy into the array
95-
referers = new JavaThing[map.size()];
96-
map.keySet().toArray(referers);
95+
referrers = new JavaThing[map.size()];
96+
map.keySet().toArray(referrers);
9797
}
98-
referersLen = -1;
98+
referrersLen = -1;
9999
}
100100

101101

@@ -134,15 +134,15 @@ public void visitReferencedObjects(JavaHeapObjectVisitor v) {
134134
}
135135

136136
void addReferenceFrom(JavaHeapObject other) {
137-
if (referersLen == 0) {
138-
referers = new JavaThing[1]; // It was null
139-
} else if (referersLen == referers.length) {
140-
JavaThing[] copy = new JavaThing[(3 * (referersLen + 1)) / 2];
141-
System.arraycopy(referers, 0, copy, 0, referersLen);
142-
referers = copy;
137+
if (referrersLen == 0) {
138+
referrers = new JavaThing[1]; // It was null
139+
} else if (referrersLen == referrers.length) {
140+
JavaThing[] copy = new JavaThing[(3 * (referrersLen + 1)) / 2];
141+
System.arraycopy(referrers, 0, copy, 0, referrersLen);
142+
referrers = copy;
143143
}
144-
referers[referersLen++] = other;
145-
// We just append to referers here. Measurements have shown that
144+
referrers[referrersLen++] = other;
145+
// We just append to referrers here. Measurements have shown that
146146
// around 10% to 30% are duplicates, so it's better to just append
147147
// blindly and screen out all the duplicates at once.
148148
}
@@ -164,26 +164,26 @@ public Root getRoot() {
164164
*
165165
* @return an Enumeration of JavaHeapObject instances
166166
*/
167-
public Enumeration<JavaThing> getReferers() {
168-
if (referersLen != -1) {
167+
public Enumeration<JavaThing> getReferrers() {
168+
if (referrersLen != -1) {
169169
throw new RuntimeException("not resolved: " + getIdString());
170170
}
171171
return new Enumeration<JavaThing>() {
172172

173173
private int num = 0;
174174

175175
public boolean hasMoreElements() {
176-
return referers != null && num < referers.length;
176+
return referrers != null && num < referrers.length;
177177
}
178178

179179
public JavaThing nextElement() {
180-
return referers[num++];
180+
return referrers[num++];
181181
}
182182
};
183183
}
184184

185185
/**
186-
* Given other, which the caller promises is in referers, determines if
186+
* Given other, which the caller promises is in referrers, determines if
187187
* the reference is only a weak reference.
188188
*/
189189
public boolean refersOnlyWeaklyTo(Snapshot ss, JavaThing other) {

test/lib/jdk/test/lib/hprof/model/Root.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@
4646
public class Root {
4747

4848
private long id; // ID of the JavaThing we refer to
49-
private long refererId; // Thread or Class responsible for this, or 0
50-
private int index = -1; // Index in Snapshot.roots
49+
private long referrerId; // Thread or Class responsible for this, or 0
50+
private int index = -1; // Index in Snapshot.roots
5151
private int type;
5252
private String description;
53-
private JavaHeapObject referer = null;
53+
private JavaHeapObject referrer = null;
5454
private StackTrace stackTrace = null;
5555

5656
// Values for type. Higher values are more interesting -- see getType().
@@ -68,15 +68,15 @@ public class Root {
6868
public final static int JAVA_STATIC = 9;
6969

7070

71-
public Root(long id, long refererId, int type, String description) {
72-
this(id, refererId, type, description, null);
71+
public Root(long id, long referrerId, int type, String description) {
72+
this(id, referrerId, type, description, null);
7373
}
7474

7575

76-
public Root(long id, long refererId, int type, String description,
76+
public Root(long id, long referrerId, int type, String description,
7777
StackTrace stackTrace) {
7878
this.id = id;
79-
this.refererId = refererId;
79+
this.referrerId = referrerId;
8080
this.type = type;
8181
this.description = description;
8282
this.stackTrace = stackTrace;
@@ -137,12 +137,12 @@ public Root mostInteresting(Root other) {
137137
* Get the object that's responsible for this root, if there is one.
138138
* This will be null, a Thread object, or a Class object.
139139
*/
140-
public JavaHeapObject getReferer() {
141-
return referer;
140+
public JavaHeapObject getReferrer() {
141+
return referrer;
142142
}
143143

144-
public long getRefererId() {
145-
return refererId;
144+
public long getReferrerId() {
145+
return referrerId;
146146
}
147147

148148
/**
@@ -161,8 +161,8 @@ public int getIndex() {
161161
}
162162

163163
void resolve(Snapshot ss) {
164-
if (refererId != 0) {
165-
referer = ss.findThing(refererId);
164+
if (referrerId != 0) {
165+
referrer = ss.findThing(referrerId);
166166
}
167167
if (stackTrace != null) {
168168
stackTrace.resolve(ss);

test/lib/jdk/test/lib/hprof/model/Snapshot.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ public void resolve(boolean calculateRefs) {
300300
}
301301
int count = 0;
302302
for (JavaHeapObject t : heapObjects.values()) {
303-
t.setupReferers();
303+
t.setupReferrers();
304304
++count;
305305
if (calculateRefs && count % DOT_LIMIT == 0) {
306306
System.out.print(".");
@@ -461,11 +461,11 @@ public List<ThreadObject> getThreads() {
461461
if (curr.getRoot() != null) {
462462
result.addElement(chain);
463463
// Even though curr is in the rootset, we want to explore its
464-
// referers, because they might be more interesting.
464+
// referrers, because they might be more interesting.
465465
}
466-
Enumeration<JavaThing> referers = curr.getReferers();
467-
while (referers.hasMoreElements()) {
468-
JavaHeapObject t = (JavaHeapObject) referers.nextElement();
466+
Enumeration<JavaThing> referrers = curr.getReferrers();
467+
while (referrers.hasMoreElements()) {
468+
JavaHeapObject t = (JavaHeapObject)referrers.nextElement();
469469
if (t != null && !visited.containsKey(t)) {
470470
if (includeWeak || !t.refersOnlyWeaklyTo(this, curr)) {
471471
visited.put(t, t);

0 commit comments

Comments
 (0)