Skip to content

Commit

Permalink
8320349: Simplify FileChooserSymLinkTest.java by using single-window …
Browse files Browse the repository at this point in the history
…testUI

Reviewed-by: serb
  • Loading branch information
aivanov-jdk committed Dec 5, 2023
1 parent 18c7922 commit b1cb374
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,12 @@
*/

import java.awt.BorderLayout;
import java.awt.Window;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.beans.PropertyChangeEvent;
import java.beans.PropertyChangeListener;
import java.io.File;
import java.util.Arrays;
import java.util.List;

import javax.swing.JCheckBox;
import javax.swing.JFileChooser;
Expand Down Expand Up @@ -118,7 +116,7 @@ public static void main(String[] args) throws Exception {
.awaitAndCheck();
}

private static List<Window> createTestUI() {
private static JFrame createTestUI() {
frame = new JFrame("JFileChooser Symbolic Link test");
panel = new JPanel(new BorderLayout());
multiSelection = new JCheckBox("Enable Multi-Selection");
Expand Down Expand Up @@ -159,6 +157,6 @@ public void propertyChange(PropertyChangeEvent evt) {
frame.add(panel, BorderLayout.NORTH);
frame.add(jfc, BorderLayout.CENTER);
frame.pack();
return List.of(frame);
return frame;
}
}

3 comments on commit b1cb374

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on b1cb374 Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on b1cb374 Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-b1cb3743 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit b1cb3743 from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 5 Dec 2023 and was reviewed by Sergey Bylokhov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-b1cb3743:backport-GoeLin-b1cb3743
$ git checkout backport-GoeLin-b1cb3743
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-b1cb3743

Please sign in to comment.