Skip to content

Commit b7945bc

Browse files
dafedafeTobiHartmann
authored andcommitted
8303154: Investigate and improve instruction cache flushing during compilation
Reviewed-by: thartmann, kvn
1 parent eefbaa2 commit b7945bc

File tree

7 files changed

+0
-11
lines changed

7 files changed

+0
-11
lines changed

src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -791,7 +791,6 @@ AdapterHandlerEntry* SharedRuntime::generate_i2c2i_adapters(MacroAssembler *masm
791791

792792
gen_c2i_adapter(masm, total_args_passed, comp_args_on_stack, sig_bt, regs, skip_fixup);
793793

794-
__ flush();
795794
return AdapterHandlerLibrary::new_entry(fingerprint, i2c_entry, c2i_entry, c2i_unverified_entry, c2i_no_clinit_check_entry);
796795
}
797796

src/hotspot/cpu/arm/sharedRuntime_arm.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,6 @@ AdapterHandlerEntry* SharedRuntime::generate_i2c2i_adapters(MacroAssembler *masm
645645
address c2i_entry = __ pc();
646646
gen_c2i_adapter(masm, total_args_passed, comp_args_on_stack, sig_bt, regs, skip_fixup);
647647

648-
__ flush();
649648
return AdapterHandlerLibrary::new_entry(fingerprint, i2c_entry, c2i_entry, c2i_unverified_entry);
650649
}
651650

src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,6 @@ AdapterHandlerEntry* SharedRuntime::generate_i2c2i_adapters(MacroAssembler *masm
681681

682682
gen_c2i_adapter(masm, total_args_passed, comp_args_on_stack, sig_bt, regs, skip_fixup);
683683

684-
__ flush();
685684
return AdapterHandlerLibrary::new_entry(fingerprint, i2c_entry, c2i_entry, c2i_unverified_entry, c2i_no_clinit_check_entry);
686685
}
687686

src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -968,7 +968,6 @@ AdapterHandlerEntry* SharedRuntime::generate_i2c2i_adapters(MacroAssembler *masm
968968

969969
gen_c2i_adapter(masm, total_args_passed, comp_args_on_stack, sig_bt, regs, skip_fixup);
970970

971-
__ flush();
972971
return AdapterHandlerLibrary::new_entry(fingerprint, i2c_entry, c2i_entry, c2i_unverified_entry);
973972
}
974973

src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1041,7 +1041,6 @@ AdapterHandlerEntry* SharedRuntime::generate_i2c2i_adapters(MacroAssembler *masm
10411041

10421042
gen_c2i_adapter(masm, total_args_passed, comp_args_on_stack, sig_bt, regs, skip_fixup);
10431043

1044-
__ flush();
10451044
return AdapterHandlerLibrary::new_entry(fingerprint, i2c_entry, c2i_entry, c2i_unverified_entry, c2i_no_clinit_check_entry);
10461045
}
10471046

src/hotspot/share/c1/c1_Compilation.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,6 @@ void Compilation::emit_code_epilog(LIR_Assembler* assembler) {
313313
// Emit the handler to remove the activation from the stack and
314314
// dispatch to the caller.
315315
offsets()->set_value(CodeOffsets::UnwindHandler, assembler->emit_unwind_handler());
316-
317-
// done
318-
masm()->flush();
319316
}
320317

321318

src/hotspot/share/code/codeCache.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -628,9 +628,6 @@ void CodeCache::commit(CodeBlob* cb) {
628628
if (cb->is_adapter_blob()) {
629629
heap->set_adapter_count(heap->adapter_count() + 1);
630630
}
631-
632-
// flush the hardware I-cache
633-
ICache::invalidate_range(cb->content_begin(), cb->content_size());
634631
}
635632

636633
bool CodeCache::contains(void *p) {

0 commit comments

Comments
 (0)