Skip to content

Commit

Permalink
8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364
Browse files Browse the repository at this point in the history 
Reviewed-by: tschatzl, zgu, gli
  • Loading branch information
@albertnetymk
albertnetymk committed Jun 11, 2024
1 parent 4d6064a commit badf1cb
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions test/hotspot/gtest/gc/shared/test_collectorPolicy.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -212,18 +212,6 @@ class TestGenCollectorPolicy {
// depends on so many other configurable variables. These tests only try to
// verify that there are some basic rules for NewSize honored by the policies.

// If NewSize has been ergonomically set, the collector policy
// should use it for min
// This test doesn't work with 64k pages. See JDK-8331675.
#if !defined(PPC)
TEST_VM(CollectorPolicy, young_min_ergo) {
TestGenCollectorPolicy::SetNewSizeErgo setter(20 * M);
TestGenCollectorPolicy::CheckYoungMin checker(20 * M);

TestGenCollectorPolicy::TestWrapper::test(&setter, &checker);
}
#endif

// If NewSize has been ergonomically set, the collector policy
// should use it for min but calculate the initial young size
// using NewRatio.
Expand Down

3 comments on commit badf1cb

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@RealCLanger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk:jdk23

@openjdk
Copy link

@openjdk openjdk bot commented on badf1cb Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RealCLanger the backport was successfully created on the branch backport-RealCLanger-badf1cb9-jdk23 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk23, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit badf1cb9 from the openjdk/jdk repository.

The commit being backported was authored by Albert Mingkun Yang on 11 Jun 2024 and was reviewed by Thomas Schatzl, Zhengyu Gu and Guoxiong Li.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-RealCLanger-badf1cb9-jdk23:backport-RealCLanger-badf1cb9-jdk23
$ git checkout backport-RealCLanger-badf1cb9-jdk23
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-RealCLanger-badf1cb9-jdk23

Please sign in to comment.