Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8273958: gtest/MetaspaceGtests executes unnecessary tests in debug bu… 
…ilds

Reviewed-by: jiefu
  • Loading branch information
@tstuefe
tstuefe committed Sep 18, 2021
1 parent 2a2e919 commit bb9d142
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions test/hotspot/jtreg/gtest/MetaspaceGtests.java
View file
Expand Up @@ -32,10 +32,10 @@
/* @test id=reclaim-none-debug
* @bug 8251158
* @summary Run metaspace-related gtests for reclaim policy none (with verifications)
* @requires vm.debug
* @library /test/lib
* @modules java.base/jdk.internal.misc
* java.xml
* @requires vm.debug
* @requires vm.flagless
* @run main/native GTestWrapper --gtest_filter=metaspace* -XX:MetaspaceReclaimPolicy=none -XX:+UnlockDiagnosticVMOptions -XX:VerifyMetaspaceInterval=3
*/
Expand All @@ -46,6 +46,7 @@
* @library /test/lib
* @modules java.base/jdk.internal.misc
* java.xml
* @requires vm.debug == false
* @requires vm.flagless
* @run main/native GTestWrapper --gtest_filter=metaspace* -XX:MetaspaceReclaimPolicy=none
*/
Expand All @@ -56,10 +57,10 @@
/* @test id=reclaim-aggressive-debug
* @bug 8251158
* @summary Run metaspace-related gtests for reclaim policy aggressive (with verifications)
* @requires vm.debug
* @library /test/lib
* @modules java.base/jdk.internal.misc
* java.xml
* @requires vm.debug
* @requires vm.flagless
* @run main/native GTestWrapper --gtest_filter=metaspace* -XX:MetaspaceReclaimPolicy=aggressive -XX:+UnlockDiagnosticVMOptions -XX:VerifyMetaspaceInterval=3
*/
Expand All @@ -70,6 +71,7 @@
* @library /test/lib
* @modules java.base/jdk.internal.misc
* java.xml
* @requires vm.debug == false
* @requires vm.flagless
* @run main/native GTestWrapper --gtest_filter=metaspace* -XX:MetaspaceReclaimPolicy=aggressive
*/
Expand All @@ -79,10 +81,10 @@

/* @test id=balanced-with-guards
* @summary Run metaspace-related gtests with allocation guards enabled
* @requires vm.debug
* @library /test/lib
* @modules java.base/jdk.internal.misc
* java.xml
* @requires vm.debug
* @requires vm.flagless
* @run main/native GTestWrapper --gtest_filter=metaspace* -XX:+UnlockDiagnosticVMOptions -XX:VerifyMetaspaceInterval=3 -XX:+MetaspaceGuardAllocations
*/
Expand All @@ -92,10 +94,10 @@

/* @test id=balanced-no-ccs
* @summary Run metaspace-related gtests with compressed class pointers off
* @requires vm.bits == 64
* @library /test/lib
* @modules java.base/jdk.internal.misc
* java.xml
* @requires vm.bits == 64
* @requires vm.flagless
* @run main/native GTestWrapper --gtest_filter=metaspace* -XX:MetaspaceReclaimPolicy=balanced -XX:-UseCompressedClassPointers
*/

3 comments on commit bb9d142

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@tstuefe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u

@openjdk
Copy link

@openjdk openjdk bot commented on bb9d142 Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstuefe the backport was successfully created on the branch tstuefe-backport-bb9d1427 in my personal fork of openjdk/jdk17u. To create a pull request with this backport targeting openjdk/jdk17u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit bb9d1427 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 18 Sep 2021 and was reviewed by Jie Fu.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u:

$ git fetch https://github.com/openjdk-bots/jdk17u tstuefe-backport-bb9d1427:tstuefe-backport-bb9d1427
$ git checkout tstuefe-backport-bb9d1427
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u tstuefe-backport-bb9d1427

Please sign in to comment.