Skip to content
Permalink
Browse files
8264337: VM crashed when -XX:+VerifySharedSpaces
Reviewed-by: minqi, ccheung, shade
  • Loading branch information
Yi Yang authored and shipilev committed Mar 30, 2021
1 parent 1a681fa commit bcdf4694e07178de7d218f0dc21bda1c92e8f456
@@ -1657,7 +1657,7 @@ char* FileMapInfo::map_bitmap_region() {
return NULL;
}

if (VerifySharedSpaces && !region_crc_check(bitmap_base, si->used_aligned(), si->crc())) {
if (VerifySharedSpaces && !region_crc_check(bitmap_base, si->used(), si->crc())) {
log_error(cds)("relocation bitmap CRC error");
if (!os::unmap_memory(bitmap_base, si->used_aligned())) {
fatal("os::unmap_memory of relocation bitmap failed");
@@ -0,0 +1,44 @@
/*
* Copyright (c) 2021, Alibaba Group Holding Limited. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*
*/

/*
* @test
* @bug 8264337
* @summary test default cds archive when turning on VerifySharedSpaces
* @requires vm.cds
* @library /test/lib
* @run driver VerifyWithDefaultArchive
*/

import jdk.test.lib.process.ProcessTools;
import jdk.test.lib.process.OutputAnalyzer;

public class VerifyWithDefaultArchive {
public static void main(String... args) throws Exception {
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder("-Xlog:cds", "-XX:+VerifySharedSpaces", "-version");
OutputAnalyzer out = new OutputAnalyzer(pb.start());
out.shouldContain("OpenJDK");
out.shouldHaveExitValue(0);
}
}

1 comment on commit bcdf469

@openjdk-notifier

This comment has been minimized.

Copy link

@openjdk-notifier openjdk-notifier bot commented on bcdf469 Mar 30, 2021

Please sign in to comment.