Skip to content

Commit

Permalink
8282900: runtime/stringtable/StringTableCleaningTest.java verify unav…
Browse files Browse the repository at this point in the history
…ailable at this moment

Reviewed-by: coleenp, dholmes
  • Loading branch information
robehn committed Oct 5, 2022
1 parent 979efd4 commit bd90c4c
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions src/hotspot/share/classfile/stringTable.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@
#include "oops/weakHandle.inline.hpp"
#include "runtime/atomic.hpp"
#include "runtime/handles.inline.hpp"
#include "runtime/interfaceSupport.inline.hpp"
#include "runtime/mutexLocker.hpp"
#include "runtime/safepointVerifiers.hpp"
#include "runtime/timerTrace.hpp"
#include "runtime/interfaceSupport.inline.hpp"
#include "services/diagnosticCommand.hpp"
#include "utilities/concurrentHashTable.inline.hpp"
#include "utilities/concurrentHashTableTasks.inline.hpp"
Expand Down Expand Up @@ -603,11 +603,8 @@ class VerifyStrings : StackObj {

// This verification is part of Universe::verify() and needs to be quick.
void StringTable::verify() {
Thread* thr = Thread::current();
VerifyStrings vs;
if (!_local_table->try_scan(thr, vs)) {
log_info(stringtable)("verify unavailable at this moment");
}
_local_table->do_safepoint_scan(vs);
}

// Verification and comp
Expand Down Expand Up @@ -643,9 +640,7 @@ class VerifyCompStrings : StackObj {
size_t StringTable::verify_and_compare_entries() {
Thread* thr = Thread::current();
VerifyCompStrings vcs;
if (!_local_table->try_scan(thr, vcs)) {
log_info(stringtable)("verify unavailable at this moment");
}
_local_table->do_scan(thr, vcs);
return vcs._errors;
}

Expand Down

1 comment on commit bd90c4c

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.