Skip to content

Commit bf442c5

Browse files
committed
8253539: Remove unused JavaThread functions for set_last_Java_fp/pc
Reviewed-by: rehn, dholmes
1 parent dd2c456 commit bf442c5

File tree

9 files changed

+7
-35
lines changed

9 files changed

+7
-35
lines changed

src/hotspot/cpu/aarch64/javaFrameAnchor_aarch64.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.
33
* Copyright (c) 2014, Red Hat Inc. All rights reserved.
44
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
55
*
@@ -80,8 +80,6 @@
8080

8181
void set_last_Java_sp(intptr_t* sp) { _last_Java_sp = sp; OrderAccess::release(); }
8282

83-
intptr_t* last_Java_fp(void) { return _last_Java_fp; }
84-
// Assert (last_Java_sp == NULL || fp == NULL)
85-
void set_last_Java_fp(intptr_t* fp) { OrderAccess::release(); _last_Java_fp = fp; }
83+
intptr_t* last_Java_fp(void) { return _last_Java_fp; }
8684

8785
#endif // CPU_AARCH64_JAVAFRAMEANCHOR_AARCH64_HPP

src/hotspot/cpu/arm/javaFrameAnchor_arm.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2008, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2008, 2020, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -79,8 +79,6 @@
7979

8080
void set_last_Java_sp(intptr_t* sp) { _last_Java_sp = sp; }
8181

82-
intptr_t* last_Java_fp(void) { return _last_Java_fp; }
83-
// Assert (last_Java_sp == NULL || fp == NULL)
84-
void set_last_Java_fp(intptr_t* fp) { _last_Java_fp = fp; }
82+
intptr_t* last_Java_fp(void) { return _last_Java_fp; }
8583

8684
#endif // CPU_ARM_JAVAFRAMEANCHOR_ARM_HPP

src/hotspot/cpu/x86/javaFrameAnchor_x86.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -78,8 +78,6 @@
7878

7979
void set_last_Java_sp(intptr_t* sp) { _last_Java_sp = sp; }
8080

81-
intptr_t* last_Java_fp(void) { return _last_Java_fp; }
82-
// Assert (last_Java_sp == NULL || fp == NULL)
83-
void set_last_Java_fp(intptr_t* fp) { _last_Java_fp = fp; }
81+
intptr_t* last_Java_fp(void) { return _last_Java_fp; }
8482

8583
#endif // CPU_X86_JAVAFRAMEANCHOR_X86_HPP

src/hotspot/os_cpu/bsd_x86/thread_bsd_x86.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@
3333
frame pd_last_frame();
3434

3535
public:
36-
// Mutators are highly dangerous....
37-
intptr_t* last_Java_fp() { return _anchor.last_Java_fp(); }
38-
void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
39-
4036
static ByteSize last_Java_fp_offset() {
4137
return byte_offset_of(JavaThread, _anchor) + JavaFrameAnchor::last_Java_fp_offset();
4238
}

src/hotspot/os_cpu/linux_aarch64/thread_linux_aarch64.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@
4444
frame pd_last_frame();
4545

4646
public:
47-
// Mutators are highly dangerous....
48-
intptr_t* last_Java_fp() { return _anchor.last_Java_fp(); }
49-
void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
50-
5147
static ByteSize last_Java_fp_offset() {
5248
return byte_offset_of(JavaThread, _anchor) + JavaFrameAnchor::last_Java_fp_offset();
5349
}

src/hotspot/os_cpu/linux_arm/thread_linux_arm.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@
4040
frame pd_last_frame();
4141

4242
public:
43-
intptr_t* last_Java_fp() { return _anchor.last_Java_fp(); }
44-
void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
45-
void set_last_Java_pc(address pc) { _anchor.set_last_Java_pc(pc); }
46-
4743
static ByteSize last_Java_fp_offset() {
4844
return byte_offset_of(JavaThread, _anchor) + JavaFrameAnchor::last_Java_fp_offset();
4945
}

src/hotspot/os_cpu/linux_x86/thread_linux_x86.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@
3333
frame pd_last_frame();
3434

3535
public:
36-
// Mutators are highly dangerous....
37-
intptr_t* last_Java_fp() { return _anchor.last_Java_fp(); }
38-
void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
39-
4036
static ByteSize last_Java_fp_offset() {
4137
return byte_offset_of(JavaThread, _anchor) + JavaFrameAnchor::last_Java_fp_offset();
4238
}

src/hotspot/os_cpu/windows_x86/thread_windows_x86.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@
4040
frame pd_last_frame();
4141

4242
public:
43-
// Mutators are highly dangerous....
44-
intptr_t* last_Java_fp() { return _anchor.last_Java_fp(); }
45-
void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
46-
4743
static ByteSize last_Java_fp_offset() {
4844
return byte_offset_of(JavaThread, _anchor) + JavaFrameAnchor::last_Java_fp_offset();
4945
}

src/hotspot/share/runtime/javaFrameAnchor.hpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -85,8 +85,6 @@ friend class JavaCallWrapper;
8585
JavaFrameAnchor() { clear(); }
8686
JavaFrameAnchor(JavaFrameAnchor *src) { copy(src); }
8787

88-
void set_last_Java_pc(address pc) { _last_Java_pc = pc; }
89-
9088
// Assembly stub generation helpers
9189

9290
static ByteSize last_Java_sp_offset() { return byte_offset_of(JavaFrameAnchor, _last_Java_sp); }

0 commit comments

Comments
 (0)