Skip to content

Commit

Permalink
8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/…
Browse files Browse the repository at this point in the history 
…CompensatedSums.java

Reviewed-by: bpb
  • Loading branch information
@rgiulietti
rgiulietti committed Oct 20, 2022
1 parent d5a1521 commit c08ff2c
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,13 @@ public void testCompensatedSums() {
}

Assert.assertTrue(jdkParallelStreamError <= goodParallelStreamError);
Assert.assertTrue(badParallelStreamError >= jdkParallelStreamError);
/*
* Due to floating-point addition being inherently non-associative,
* and due to the unpredictable scheduling of the threads used
* in parallel streams, this assertion can fail intermittently,
* hence is suppressed for now.
*/
// Assert.assertTrue(badParallelStreamError >= jdkParallelStreamError);

Assert.assertTrue(goodSequentialStreamError >= jdkSequentialStreamError);
Assert.assertTrue(naive > jdkSequentialStreamError);
Expand Down Expand Up @@ -144,4 +150,4 @@ static double computeFinalSum(double[] summands) {
ll[2] += rr[2];
};

}
}

5 comments on commit c08ff2c

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@mrserb
Copy link
Member

@mrserb mrserb commented on c08ff2c Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on c08ff2c Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb the backport was successfully created on the branch mrserb-backport-c08ff2c7 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c08ff2c7 from the openjdk/jdk repository.

The commit being backported was authored by Raffaello Giulietti on 20 Oct 2022 and was reviewed by Brian Burkhalter.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev mrserb-backport-c08ff2c7:mrserb-backport-c08ff2c7
$ git checkout mrserb-backport-c08ff2c7
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev mrserb-backport-c08ff2c7

@mrserb
Copy link
Member

@mrserb mrserb commented on c08ff2c Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on c08ff2c Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb the backport was successfully created on the branch mrserb-backport-c08ff2c7 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c08ff2c7 from the openjdk/jdk repository.

The commit being backported was authored by Raffaello Giulietti on 20 Oct 2022 and was reviewed by Brian Burkhalter.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev mrserb-backport-c08ff2c7:mrserb-backport-c08ff2c7
$ git checkout mrserb-backport-c08ff2c7
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev mrserb-backport-c08ff2c7

Please sign in to comment.