Skip to content

Commit

Permalink
8324998: Add test cases for String.regionMatches comparing Turkic dot…
Browse files Browse the repository at this point in the history 
…ted/dotless I with uppercase latin I

Reviewed-by: naoto, iris
  • Loading branch information
Eirik Bjørsnøs committed Jan 30, 2024
1 parent 8892d45 commit c3c1d5b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/jdk/java/lang/String/CompactString/RegionMatches.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -96,9 +96,13 @@ public Object[][] provider() {
// Turkish I with dot
new Object[] { "\u0130", false, 0, "i", 0, 1, false },
new Object[] { "\u0130", true, 0, "i", 0, 1, true },
new Object[] { "\u0130", false, 0, "I", 0, 1, false },
new Object[] { "\u0130", true, 0, "I", 0, 1, true },
// i without dot
new Object[] { "\u0131", false, 0, "i", 0, 1, false },
new Object[] { "\u0131", true, 0, "i", 0, 1, true },
new Object[] { "\u0131", false, 0, "I", 0, 1, false },
new Object[] { "\u0131", true, 0, "I", 0, 1, true },
// Exhaustive list of 1-char latin1 strings that match
// case-insensitively:
// for (char c1 = 0; c1 < 255; c1++) {
Expand Down

3 comments on commit c3c1d5b

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@SoniaZaldana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on c3c1d5b Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SoniaZaldana the backport was successfully created on the branch backport-SoniaZaldana-c3c1d5bd in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c3c1d5bd from the openjdk/jdk repository.

The commit being backported was authored by Eirik Bjørsnøs on 30 Jan 2024 and was reviewed by Naoto Sato and Iris Clark.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-SoniaZaldana-c3c1d5bd:backport-SoniaZaldana-c3c1d5bd
$ git checkout backport-SoniaZaldana-c3c1d5bd
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-SoniaZaldana-c3c1d5bd

Please sign in to comment.