Skip to content
Permalink
Browse files
8264686: ClhsdbTestConnectArgument.java should use SATestUtils::valid…
…ateSADebugDPrivileges

Reviewed-by: cjplummer
  • Loading branch information
YaSuenag committed Apr 5, 2021
1 parent b7baca7 commit c41cd1521f2f95fbdbd72c4d7f69c323904e8f43
Showing with 1 addition and 12 deletions.
  1. +1 −12 test/hotspot/jtreg/serviceability/sa/sadebugd/ClhsdbTestConnectArgument.java
@@ -44,18 +44,7 @@

public static void main(String[] args) throws Exception {
SATestUtils.skipIfCannotAttach(); // throws SkippedException if attach not expected to work.

if (SATestUtils.needsPrivileges()) {
// This tests has issues if you try adding privileges on OSX. The debugd process cannot
// be killed if you do this (because it is a root process and the test is not), so the destroy()
// call fails to do anything, and then waitFor() will time out. If you try to manually kill it with
// a "sudo kill" command, that seems to work, but then leaves the LingeredApp it was
// attached to in a stuck state for some unknown reason, causing the stopApp() call
// to timeout. For that reason we don't run this test when privileges are needed. Note
// it does appear to run fine as root, so we still allow it to run on OSX when privileges
// are not required.
throw new SkippedException("Cannot run this test on OSX if adding privileges is required.");
}
SATestUtils.validateSADebugDPrivileges();

System.out.println("Starting ClhsdbTestConnectArgument test");

1 comment on commit c41cd15

@openjdk-notifier

This comment has been minimized.

Copy link

@openjdk-notifier openjdk-notifier bot commented on c41cd15 Apr 5, 2021

Please sign in to comment.