Skip to content
Permalink
Browse files
8274265: Suspicious string concatenation in logTestUtils.inline.hpp
Reviewed-by: clanger, mbaesken
  • Loading branch information
Jesper Steen Møller authored and RealCLanger committed Sep 28, 2021
1 parent 6f4cefb commit c57a6c62baecde0bc10bfca89e0616b0c1fbb714
Showing with 2 additions and 2 deletions.
  1. +1 −1 test/hotspot/gtest/logging/logTestUtils.inline.hpp
  2. +1 −1 test/hotspot/gtest/logging/test_logFileOutput.cpp
@@ -32,7 +32,7 @@
#define LOG_TEST_STRING_LITERAL "a (hopefully) unique log message for testing"

static const char* invalid_selection_substr[] = {
"=", "+", " ", "+=", "+=*", "*+", " +", "**", "++", ".", ",", ",," ",+",
"=", "+", " ", "+=", "+=*", "*+", " +", "**", "++", ".", ",", ",,", ",+",
" *", "all+", "all*", "+all", "+all=Warning", "==Info", "=InfoWarning",
"BadTag+", "logging++", "logging*+", ",=", "gc+gc+"
};
@@ -74,7 +74,7 @@ TEST_VM(LogFileOutput, parse_invalid) {
"filecount= 2", "filesize=2 ",
"filecount=ab", "filesize=0xz",
"filecount=1MB", "filesize=99bytes",
"filesize=9999999999999999999999999"
"filesize=9999999999999999999999999",
"filecount=9999999999999999999999999"
};

5 comments on commit c57a6c6

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on c57a6c6 Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken
Copy link
Member

@MBaesken MBaesken commented on c57a6c6 Nov 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u

@openjdk
Copy link

@openjdk openjdk bot commented on c57a6c6 Nov 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch MBaesken-backport-c57a6c62 in my personal fork of openjdk/jdk17u. To create a pull request with this backport targeting openjdk/jdk17u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c57a6c62 from the openjdk/jdk repository.

The commit being backported was authored by Jesper Steen Møller on 28 Sep 2021 and was reviewed by Christoph Langer and Matthias Baesken.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u:

$ git fetch https://github.com/openjdk-bots/jdk17u MBaesken-backport-c57a6c62:MBaesken-backport-c57a6c62
$ git checkout MBaesken-backport-c57a6c62
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u MBaesken-backport-c57a6c62

@MBaesken
Copy link
Member

@MBaesken MBaesken commented on c57a6c6 Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on c57a6c6 Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch MBaesken-backport-c57a6c62 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c57a6c62 from the openjdk/jdk repository.

The commit being backported was authored by Jesper Steen Møller on 28 Sep 2021 and was reviewed by Christoph Langer and Matthias Baesken.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev MBaesken-backport-c57a6c62:MBaesken-backport-c57a6c62
$ git checkout MBaesken-backport-c57a6c62
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev MBaesken-backport-c57a6c62

Please sign in to comment.