Skip to content

Commit

Permalink
8317343: GC: Make TestHeapFreeRatio use createTestJvm
Browse files Browse the repository at this point in the history
Reviewed-by: tschatzl, iwalulya
  • Loading branch information
lkorinth committed Oct 17, 2023
1 parent 6ee6171 commit c64bd3d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/hotspot/jtreg/gc/arguments/TestHeapFreeRatio.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -27,6 +27,7 @@
* @test TestHeapFreeRatio
* @bug 8025661
* @summary Test parsing of -Xminf and -Xmaxf
* @requires vm.opt.x.Xminf == null & vm.opt.x.Xmaxf == null & vm.opt.MinHeapFreeRatio == null & vm.opt.MaxHeapFreeRatio == null
* @library /test/lib
* @library /
* @modules java.base/jdk.internal.misc
Expand All @@ -47,7 +48,7 @@ enum Validation {
}

private static void testMinMaxFreeRatio(String min, String max, Validation type) throws Exception {
ProcessBuilder pb = GCArguments.createJavaProcessBuilder(
ProcessBuilder pb = GCArguments.createTestJvm(
"-Xminf" + min,
"-Xmaxf" + max,
"-version");
Expand Down

3 comments on commit c64bd3d

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on c64bd3d Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on c64bd3d Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-c64bd3d6 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c64bd3d6 from the openjdk/jdk repository.

The commit being backported was authored by Leo Korinth on 17 Oct 2023 and was reviewed by Thomas Schatzl and Ivan Walulya.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-c64bd3d6:backport-GoeLin-c64bd3d6
$ git checkout backport-GoeLin-c64bd3d6
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-c64bd3d6

Please sign in to comment.