Skip to content

Commit

Permalink
8321025: Enable Neoverse N1 optimizations for Neoverse V2
Browse files Browse the repository at this point in the history 
Reviewed-by: ngasson, shade
  • Loading branch information
Evgeny Astigeevich committed Nov 30, 2023
1 parent 61653a1 commit c9d15f7
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/hotspot/cpu/aarch64/vm_version_aarch64.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,9 @@ void VM_Version::initialize() {
}
}

// Neoverse N1, N2 and V1
if (_cpu == CPU_ARM && (model_is(0xd0c) || model_is(0xd49) || model_is(0xd40))) {
// Neoverse N1, N2, V1, V2
if (_cpu == CPU_ARM && (model_is(0xd0c) || model_is(0xd49) ||
model_is(0xd40) || model_is(0xd4f))) {
if (FLAG_IS_DEFAULT(UseSIMDForMemoryOps)) {
FLAG_SET_DEFAULT(UseSIMDForMemoryOps, true);
}
Expand Down

7 comments on commit c9d15f7

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@pengxiaolong
Copy link

@pengxiaolong pengxiaolong commented on c9d15f7 Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on c9d15f7 Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengxiaolong To use the /backport command, you need to be in the OpenJDK census and your GitHub account needs to be linked with your OpenJDK username (how to associate your GitHub account with your OpenJDK username).

@pengxiaolong
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@pengxiaolong
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on c9d15f7 Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengxiaolong Could not automatically backport c9d15f7d to openjdk/jdk21u-dev due to conflicts in the following files:

  • src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk21u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk21u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-pengxiaolong-c9d15f7d-master

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git c9d15f7d5ee616bf48d85647ee504714ac5fafc2

# Backport the commit
$ git cherry-pick --no-commit c9d15f7d5ee616bf48d85647ee504714ac5fafc2
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport c9d15f7d5ee616bf48d85647ee504714ac5fafc2'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk21u-dev with the title Backport c9d15f7d5ee616bf48d85647ee504714ac5fafc2.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c9d15f7d from the openjdk/jdk repository.

The commit being backported was authored by Evgeny Astigeevich on 30 Nov 2023 and was reviewed by Nick Gasson and Aleksey Shipilev.

Thanks!

@openjdk
Copy link

@openjdk openjdk bot commented on c9d15f7 Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengxiaolong Could not automatically backport c9d15f7d to openjdk/jdk17u-dev due to conflicts in the following files:

  • src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk17u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk17u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-pengxiaolong-c9d15f7d-master

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git c9d15f7d5ee616bf48d85647ee504714ac5fafc2

# Backport the commit
$ git cherry-pick --no-commit c9d15f7d5ee616bf48d85647ee504714ac5fafc2
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport c9d15f7d5ee616bf48d85647ee504714ac5fafc2'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk17u-dev with the title Backport c9d15f7d5ee616bf48d85647ee504714ac5fafc2.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c9d15f7d from the openjdk/jdk repository.

The commit being backported was authored by Evgeny Astigeevich on 30 Nov 2023 and was reviewed by Nick Gasson and Aleksey Shipilev.

Thanks!

Please sign in to comment.