Skip to content
Permalink
Browse files
8275440: Remove VirtualSpaceList::is_full()
Reviewed-by: coleenp
  • Loading branch information
tstuefe committed Oct 29, 2021
1 parent de93b1d commit c9e65f8ef926c3796867558afa536770eed71cd6
Showing 3 changed files with 2 additions and 15 deletions.
@@ -200,15 +200,6 @@ bool VirtualSpaceList::contains(const MetaWord* p) const {
return false;
}

// Returns true if the vslist is not expandable and no more root chunks
// can be allocated.
bool VirtualSpaceList::is_full() const {
if (!_can_expand && _first_node != NULL && _first_node->free_words() == 0) {
return true;
}
return false;
}

// Convenience methods to return the global class-space chunkmanager
// and non-class chunkmanager, respectively.
VirtualSpaceList* VirtualSpaceList::vslist_class() {
@@ -128,10 +128,6 @@ class VirtualSpaceList : public CHeapObj<mtClass> {
// Returns true if this pointer is contained in one of our nodes.
bool contains(const MetaWord* p) const;

// Returns true if the list is not expandable and no more root chunks
// can be allocated.
bool is_full() const;

// Convenience methods to return the global class-space vslist
// and non-class vslist, respectively.
static VirtualSpaceList* vslist_class();
@@ -61,9 +61,9 @@ class ChunkManagerRandomChunkAllocTest {
return max_chunks;
}

// Return true if, after an allocation error happened, a reserve error seems likely.
// Return true if, after an allocation error happened, a reserve error seems possible.
bool could_be_reserve_error() {
return _context.vslist().is_full();
return _context.reserve_limit() < max_uintx;
}

// Return true if, after an allocation error happened, a commit error seems likely.

1 comment on commit c9e65f8

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on c9e65f8 Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.