Skip to content

Commit

Permalink
8289799: Build warning in methodData.cpp memset zero-length parameter
Browse files Browse the repository at this point in the history
Reviewed-by: jiefu, lucy
  • Loading branch information
tstuefe committed Jul 7, 2022
1 parent d1249aa commit cce77a7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/hotspot/share/oops/methodData.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,9 @@ void MethodData::initialize() {
int extra_size = extra_data_count * DataLayout::compute_size_in_bytes(0);

// Let's zero the space for the extra data
Copy::zero_to_bytes(((address)_data) + data_size, extra_size);
if (extra_size > 0) {
Copy::zero_to_bytes(((address)_data) + data_size, extra_size);
}

// Add a cell to record information about modified arguments.
// Set up _args_modified array after traps cells so that
Expand Down

7 comments on commit cce77a7

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented on cce77a7 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk19

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented on cce77a7 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented on cce77a7 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on cce77a7 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstuefe the backport was successfully created on the branch tstuefe-backport-cce77a70 in my personal fork of openjdk/jdk19. To create a pull request with this backport targeting openjdk/jdk19:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit cce77a70 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 7 Jul 2022 and was reviewed by Jie Fu and Lutz Schmidt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk19:

$ git fetch https://github.com/openjdk-bots/jdk19 tstuefe-backport-cce77a70:tstuefe-backport-cce77a70
$ git checkout tstuefe-backport-cce77a70
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk19 tstuefe-backport-cce77a70

@openjdk
Copy link

@openjdk openjdk bot commented on cce77a7 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstuefe the backport was successfully created on the branch tstuefe-backport-cce77a70 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit cce77a70 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 7 Jul 2022 and was reviewed by Jie Fu and Lutz Schmidt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev tstuefe-backport-cce77a70:tstuefe-backport-cce77a70
$ git checkout tstuefe-backport-cce77a70
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev tstuefe-backport-cce77a70

@openjdk
Copy link

@openjdk openjdk bot commented on cce77a7 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstuefe the backport was successfully created on the branch tstuefe-backport-cce77a70 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit cce77a70 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 7 Jul 2022 and was reviewed by Jie Fu and Lutz Schmidt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev tstuefe-backport-cce77a70:tstuefe-backport-cce77a70
$ git checkout tstuefe-backport-cce77a70
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev tstuefe-backport-cce77a70

Please sign in to comment.