8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect

egahlin · egahlin · commit ced88a2fd9a3 · 2022-11-11T15:49:36.000Z
Reviewed-by: clanger, mgronlun
diff --git a/src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/RandomAccessFileInstrumentor.java b/src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/RandomAccessFileInstrumentor.java
@@ -153,7 +153,7 @@ public void write(byte b[]) throws IOException {
             write(b);
             bytesWritten = b.length;
         } finally {
-            long duration = EventConfiguration.timestamp();
+            long duration = EventConfiguration.timestamp() - start;
             if (eventConfiguration.shouldCommit(duration)) {
                 FileWriteEvent.commit(start, duration, path, bytesWritten);
             }

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public void write(byte b[]) throws IOException {`
`153`	`153`	`write(b);`
`154`	`154`	`bytesWritten = b.length;`
`155`	`155`	`} finally {`
`156`		`- long duration = EventConfiguration.timestamp();`
	`156`	`+ long duration = EventConfiguration.timestamp() - start;`
`157`	`157`	`if (eventConfiguration.shouldCommit(duration)) {`
`158`	`158`	`FileWriteEvent.commit(start, duration, path, bytesWritten);`
`159`	`159`	`}`