Skip to content

Commit

Permalink
8319988: Wrong heading for inherited nested classes
Browse files Browse the repository at this point in the history
Reviewed-by: jjg
  • Loading branch information
hns committed Nov 20, 2023
1 parent 32098ce commit cee54de
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public void addInheritedSummaryLabel(TypeElement typeElement, Content content) {
? resources.getText("doclet.Nested_Classes_Interfaces_Inherited_From_Interface")
: resources.getText("doclet.Nested_Classes_Interfaces_Inherited_From_Class"));
}
var labelHeading = HtmlTree.HEADING(Headings.TypeDeclaration.SUMMARY_HEADING, label);
var labelHeading = HtmlTree.HEADING(Headings.TypeDeclaration.INHERITED_SUMMARY_HEADING, label);
labelHeading.setId(htmlIds.forInheritedClasses(typeElement));
labelHeading.add(Entity.NO_BREAK_SPACE);
labelHeading.add(classLink);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2016, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2016, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -72,8 +72,8 @@ public void test1() {
"""
<code><a href="A.html#visibleMethod()">visibleMethod</a></code>""",
"""
<h2 id="nested-classes-inherited-from-class-pkg1.A">Nested classes/interfaces in\
herited from class&nbsp;pkg1.<a href="A.html" title="class in pkg1">A</a></h2>
<h3 id="nested-classes-inherited-from-class-pkg1.A">Nested classes/interfaces in\
herited from class&nbsp;pkg1.<a href="A.html" title="class in pkg1">A</a></h3>
<code><a href="A.VisibleInner.html" title="class in pkg1">A.VisibleInner</a>, <a\
href="A.VisibleInnerExtendsInvisibleInner.html" title="class in pkg1">A.Visible\
InnerExtendsInvisibleInner</a></code></div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
/*
* @test
* @bug 4682448 4947464 5029946 8025633 8026567 8035473 8139101 8175200
8186332 8186703 8182765 8187288 8261976 8303349
8186332 8186703 8182765 8187288 8261976 8303349 8319988
* @summary Verify that the public modifier does not show up in the
* documentation for public methods, as recommended by the JLS.
* If A implements I and B extends A, B should be in the list of
Expand Down Expand Up @@ -204,9 +204,9 @@ public void test2() {
checkOutput("pkg2/Spliterator.OfDouble.html", true,
// Ensure the correct type parameters are displayed correctly
"""
<h2 id="nested-classes-inherited-from-class-pkg2.Spliterator">Nested classes/int\
<h3 id="nested-classes-inherited-from-class-pkg2.Spliterator">Nested classes/int\
erfaces inherited from interface&nbsp;pkg2.<a href="Spliterator.html" title="int\
erface in pkg2">Spliterator</a></h2>
erface in pkg2">Spliterator</a></h3>
<code><a href="Spliterator.OfDouble.html" title="interface in pkg2">Spliterator.\
OfDouble</a>, <a href="Spliterator.OfInt.html" title="interface in pkg2">Spliter\
ator.OfInt</a>&lt;<a href="Spliterator.OfInt.html" title="type parameter in Spli\
Expand Down

1 comment on commit cee54de

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.