Skip to content
Permalink
Browse files
8260571: Add PrintMetaspaceStatistics to print metaspace statistics u… 
…pon VM exit

Reviewed-by: iklam
  • Loading branch information
@tstuefe
tstuefe committed Feb 2, 2021
1 parent fe407cf commit ddd2951ba91fe3860b92d2f9bad4e0d900f1d650
Showing 2 changed files with 11 additions and 0 deletions.
3 src/hotspot/share/runtime/globals.hpp
View file
@@ -1490,6 +1490,9 @@ const intx ObjectAlignmentInBytes = 8;
product(ccstr, MetaspaceReclaimPolicy, "balanced", \
"options: balanced, aggressive, none") \
\
product(bool, PrintMetaspaceStatisticsAtExit, false, DIAGNOSTIC, \
"Print metaspace statistics upon VM exit.") \
\
product(bool, MetaspaceGuardAllocations, false, DIAGNOSTIC, \
"Metapace allocations are guarded.") \
\
8 src/hotspot/share/runtime/java.cpp
View file
@@ -328,6 +328,10 @@ void print_statistics() {
MemTracker::final_report(tty);
}

if (PrintMetaspaceStatisticsAtExit) {
MetaspaceUtils::print_basic_report(tty, 0);
}

ThreadsSMRSupport::log_statistics();
}

@@ -370,6 +374,10 @@ void print_statistics() {
MemTracker::final_report(tty);
}

if (PrintMetaspaceStatisticsAtExit) {
MetaspaceUtils::print_basic_report(tty, 0);
}

if (LogTouchedMethods && PrintTouchedMethodsAtExit) {
Method::print_touched_methods(tty);
}

3 comments on commit ddd2951

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on ddd2951 Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented on ddd2951 Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on ddd2951 Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstuefe could not automatically backport ddd2951b to openjdk/jdk11u-dev due to conflicts in the following files:

  • src/hotspot/share/runtime/globals.hpp

To manually resolve these conflicts run the following commands in your personal fork of openjdk/jdk11u-dev:

$ git checkout -b tstuefe-backport-ddd2951b
$ git fetch --no-tags https://git.openjdk.java.net/jdk ddd2951ba91fe3860b92d2f9bad4e0d900f1d650
$ git cherry-pick --no-commit ddd2951ba91fe3860b92d2f9bad4e0d900f1d650
$ # Resolve conflicts
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport ddd2951ba91fe3860b92d2f9bad4e0d900f1d650'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport ddd2951ba91fe3860b92d2f9bad4e0d900f1d650.

Please sign in to comment.