Skip to content

Commit

Permalink
8286191: misc tests fail due to JDK-8285987
Browse files Browse the repository at this point in the history
Reviewed-by: rriggs
  • Loading branch information
MBaesken committed May 10, 2022
1 parent bf0dc4f commit de8f4d0
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion test/langtools/ProblemList.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ jdk/jshell/UserJdiUserRemoteTest.java
jdk/jshell/UserInputTest.java 8169536 generic-all
jdk/jshell/ToolBasicTest.java 8265357 macosx-aarch64
jdk/jshell/HighlightUITest.java 8284144 generic-aarch64,macosx-x64,linux-x64
jdk/jshell/ExternalEditorTest.java 8286191 generic-all

###########################################################################
#
Expand Down
4 changes: 1 addition & 3 deletions test/langtools/jdk/jshell/ExternalEditorTest.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -25,8 +25,6 @@
* @test
* @summary Testing external editor.
* @bug 8143955 8080843 8163816 8143006 8169828 8171130 8162989 8210808
* @comment musl/Alpine has problems executing some shell scripts, see 8285987
* @requires !vm.musl
* @modules jdk.jshell/jdk.internal.jshell.tool
* @build ReplToolTesting CustomEditor EditorTestBase
* @run testng ExternalEditorTest
Expand Down
1 change: 0 additions & 1 deletion test/lib-test/ProblemList.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,3 @@
# More than one label is allowed but must be on the same line.
#
#############################################################################
jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java 8286191 generic-all
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ private static enum MethodGroup {
OS("isAix", "isLinux", "isOSX", "isWindows"),
VM_TYPE("isClient", "isServer", "isMinimal", "isZero", "isEmbedded"),
MODE("isInt", "isMixed", "isComp"),
IGNORED("isEmulatedClient", "isDebugBuild", "isFastDebugBuild",
IGNORED("isEmulatedClient", "isDebugBuild", "isFastDebugBuild", "isMusl",
"isSlowDebugBuild", "hasSA", "isRoot", "isTieredSupported",
"areCustomLoadersSupportedForCDS", "isDefaultCDSArchiveSupported",
"isHardenedOSX");
Expand Down

3 comments on commit de8f4d0

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luchenlin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on de8f4d0 Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luchenlin Could not automatically backport de8f4d01 to openjdk/jdk11u-dev due to conflicts in the following files:

  • test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java
  • test/langtools/ProblemList.txt
  • test/langtools/jdk/jshell/ExternalEditorTest.java
  • test/lib-test/ProblemList.txt

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-luchenlin-de8f4d01

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git de8f4d01b234f5224a687dae5db52ab31247c2da

# Backport the commit
$ git cherry-pick --no-commit de8f4d01b234f5224a687dae5db52ab31247c2da
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport de8f4d01b234f5224a687dae5db52ab31247c2da'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport de8f4d01b234f5224a687dae5db52ab31247c2da.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit de8f4d01 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 10 May 2022 and was reviewed by Roger Riggs.

Thanks!

Please sign in to comment.