Skip to content

Commit de9b971

Browse files
committed
8315933: Serial: Remove empty Generation::ensure_parsability
Reviewed-by: tschatzl, sjohanss
1 parent b48dbf6 commit de9b971

File tree

4 files changed

+1
-21
lines changed

4 files changed

+1
-21
lines changed

src/hotspot/share/gc/shared/collectedHeap.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ class CollectedHeap : public CHeapObj<mtGC> {
328328
// super::ensure_parsability so that the non-generational
329329
// part of the work gets done. See implementation of
330330
// CollectedHeap::ensure_parsability and, for instance,
331-
// that of GenCollectedHeap::ensure_parsability().
331+
// that of ParallelScavengeHeap::ensure_parsability().
332332
// The argument "retire_tlabs" controls whether existing TLABs
333333
// are merely filled or also retired, thus preventing further
334334
// allocation from them and necessitating allocation of new TLABs.

src/hotspot/share/gc/shared/genCollectedHeap.cpp

-13
Original file line numberDiff line numberDiff line change
@@ -1069,16 +1069,3 @@ void GenCollectedHeap::record_gen_tops_before_GC() {
10691069
}
10701070
}
10711071
#endif // not PRODUCT
1072-
1073-
class GenEnsureParsabilityClosure: public GenCollectedHeap::GenClosure {
1074-
public:
1075-
void do_generation(Generation* gen) {
1076-
gen->ensure_parsability();
1077-
}
1078-
};
1079-
1080-
void GenCollectedHeap::ensure_parsability(bool retire_tlabs) {
1081-
CollectedHeap::ensure_parsability(retire_tlabs);
1082-
GenEnsureParsabilityClosure ep_cl;
1083-
generation_iterate(&ep_cl, false);
1084-
}

src/hotspot/share/gc/shared/genCollectedHeap.hpp

-3
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,6 @@ class GenCollectedHeap : public CollectedHeap {
228228
size_t requested_size,
229229
size_t* actual_size) override;
230230

231-
// Ensure parsability
232-
void ensure_parsability(bool retire_tlabs) override;
233-
234231
// Total number of full collections completed.
235232
unsigned int total_full_collections_completed() {
236233
assert(_full_collections_completed <= _total_full_collections,

src/hotspot/share/gc/shared/generation.hpp

-4
Original file line numberDiff line numberDiff line change
@@ -291,10 +291,6 @@ class Generation: public CHeapObj<mtGC> {
291291
// Save the high water marks for the used space in a generation.
292292
virtual void record_spaces_top() {}
293293

294-
// Some generations may need to be "fixed-up" after some allocation
295-
// activity to make them parsable again. The default is to do nothing.
296-
virtual void ensure_parsability() {}
297-
298294
// Generations may keep statistics about collection. This method
299295
// updates those statistics. current_generation is the generation
300296
// that was most recently collected. This allows the generation to

0 commit comments

Comments
 (0)