Skip to content

Commit

Permalink
8329545: [s390x] Fix garbage value being passed in Argument Register
Browse files Browse the repository at this point in the history
Reviewed-by: amitkumar, mdoerr
  • Loading branch information
Sidraya Jayagond authored and offamitkumar committed Apr 10, 2024
1 parent 51ed69a commit e0fd6c4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/hotspot/cpu/s390/foreignGlobals_s390.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, Red Hat, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
Expand Down Expand Up @@ -166,7 +166,7 @@ static void move_stack(MacroAssembler* masm, Register tmp_reg, int in_stk_bias,
case StorageType::INTEGER:
switch (from_reg.stack_size()) {
case 8: __ mem2reg_opt(as_Register(to_reg), from_addr, true);break;
case 4: __ mem2reg_opt(as_Register(to_reg), from_addr, false);break;
case 4: __ mem2reg_signed_opt(as_Register(to_reg), from_addr);break;
default: ShouldNotReachHere();
}
break;
Expand Down

7 comments on commit e0fd6c4

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sid8606
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk22u

@openjdk
Copy link

@openjdk openjdk bot commented on e0fd6c4 Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sid8606 the backport was successfully created on the branch backport-sid8606-e0fd6c4c in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e0fd6c4c from the openjdk/jdk repository.

The commit being backported was authored by Sidraya Jayagond on 10 Apr 2024 and was reviewed by Amit Kumar and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-sid8606-e0fd6c4c:backport-sid8606-e0fd6c4c
$ git checkout backport-sid8606-e0fd6c4c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-sid8606-e0fd6c4c

⚠️ @sid8606 You are not yet a collaborator in my fork openjdk-bots/jdk22u. An invite will be sent out and you need to accept it before you can proceed.

@sid8606
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jkd21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e0fd6c4 Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sid8606 The target repository jkd21u-dev is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk21u, openjdk/jdk21u-dev, openjdk/jdk22u, openjdk/jdk7u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx17u, openjdk/jfx21u, openjdk/jfx22u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/shenandoah-jdk21u, openjdk/shenandoah-jdk8u.
Supplying the organization/group prefix is optional.

@sid8606
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e0fd6c4 Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sid8606 the backport was successfully created on the branch backport-sid8606-e0fd6c4c in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e0fd6c4c from the openjdk/jdk repository.

The commit being backported was authored by Sidraya Jayagond on 10 Apr 2024 and was reviewed by Amit Kumar and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-sid8606-e0fd6c4c:backport-sid8606-e0fd6c4c
$ git checkout backport-sid8606-e0fd6c4c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-sid8606-e0fd6c4c

⚠️ @sid8606 You are not yet a collaborator in my fork openjdk-bots/jdk21u-dev. An invite will be sent out and you need to accept it before you can proceed.

Please sign in to comment.