Skip to content

Commit

Permalink
8288651: CDS test HelloUnload.java should not use literal string as C…
Browse files Browse the repository at this point in the history
…lassLoader name

Reviewed-by: coleenp, iklam
  • Loading branch information
calvinccheung committed Jun 27, 2022
1 parent 40bf3b1 commit e322e77
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2019, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -73,7 +73,7 @@ public static void main(String args[]) throws Exception {
}

URLClassLoader urlClassLoader =
new URLClassLoader("HelloClassLoader", urls, null);
new URLClassLoader("HelloClassLoader" + System.currentTimeMillis(), urls, null);
Class c = Class.forName(className, true, urlClassLoader);
if (keepAlive) {
keptC = c;
Expand Down

3 comments on commit e322e77

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e322e77 Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e322e77 Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-e322e77e in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e322e77e from the openjdk/jdk repository.

The commit being backported was authored by Calvin Cheung on 27 Jun 2022 and was reviewed by Coleen Phillimore and Ioi Lam.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-e322e77e:GoeLin-backport-e322e77e
$ git checkout GoeLin-backport-e322e77e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-e322e77e

Please sign in to comment.