Skip to content

Commit

Permalink
8314275: Incorrect stepping in switch
Browse files Browse the repository at this point in the history
Reviewed-by: vromero
  • Loading branch information
biboudis committed Feb 9, 2024
1 parent cc276ff commit e3dc6a7
Show file tree
Hide file tree
Showing 2 changed files with 84 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1428,6 +1428,11 @@ private void handleSwitch(JCTree swtch, JCExpression selector, List<JCCase> case
code.put4(caseidx + 4, offsets[i]);
}
}

if (swtch instanceof JCSwitchExpression) {
// Emit line position for the end of a switch expression
code.statBegin(TreeInfo.endPos(swtch));
}
}
code.endScopes(limit);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 8314275
* @summary Tests a line number table attribute for switch expression
* @library /tools/lib /tools/javac/lib ../lib
* @enablePreview
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* jdk.compiler/com.sun.tools.javac.util
* java.base/jdk.internal.classfile.impl
* @build toolbox.ToolBox InMemoryFileManager TestBase
* @build LineNumberTestBase TestCase
* @run main T8314275
*/
import java.util.List;
public class T8314275 extends LineNumberTestBase {
public static void main(String[] args) throws Exception {
new T8314275().test();
}

public void test() throws Exception {
test(List.of(TEST_CASE));
}

private static final TestCase[] TEST_CASE = new TestCase[] {
new TestCase("""
public class T8314275Expression { // 1
private static double multiply(Integer i) { // 2
double cr = 15; // 3
cr = switch (i) { // 4
case 1 -> cr * 1; // 5
case 2 -> cr * 2; // 6
default -> cr * 4; // 7
}; // 8
return cr; // 9
} //10
} //11
""",
List.of(1, 3, 4, 5, 6, 7, 8, 9),
"T8314275Expression"),
new TestCase("""
public class T8314275Statement { // 1
private static double multiply(Integer i) { // 2
double cr = 15; // 3
switch (i) { // 4
case 1: cr *= 1; break; // 5
case 2: cr *= 2; break; // 6
default: cr *= 4; // 7
}; // 8
return cr; // 9
} //10
} //11
""",
List.of(1, 3, 4, 5, 6, 7, 9),
"T8314275Statement")
};
}

7 comments on commit e3dc6a7

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biboudis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u

@openjdk
Copy link

@openjdk openjdk bot commented on e3dc6a7 Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biboudis the backport was successfully created on the branch backport-biboudis-e3dc6a7a in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e3dc6a7a from the openjdk/jdk repository.

The commit being backported was authored by Aggelos Biboudis on 9 Feb 2024 and was reviewed by Vicente Romero.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git backport-biboudis-e3dc6a7a:backport-biboudis-e3dc6a7a
$ git checkout backport-biboudis-e3dc6a7a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git backport-biboudis-e3dc6a7a

@biboudis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk22u

@openjdk
Copy link

@openjdk openjdk bot commented on e3dc6a7 Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biboudis the backport was successfully created on the branch backport-biboudis-e3dc6a7a in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e3dc6a7a from the openjdk/jdk repository.

The commit being backported was authored by Aggelos Biboudis on 9 Feb 2024 and was reviewed by Vicente Romero.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-biboudis-e3dc6a7a:backport-biboudis-e3dc6a7a
$ git checkout backport-biboudis-e3dc6a7a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-biboudis-e3dc6a7a

⚠️ @biboudis You are not yet a collaborator in my fork openjdk-bots/jdk22u. An invite will be sent out and you need to accept it before you can proceed.

@biboudis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u

@openjdk
Copy link

@openjdk openjdk bot commented on e3dc6a7 Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biboudis the backport was successfully created on the branch backport-biboudis-e3dc6a7a in my personal fork of openjdk/jdk17u. To create a pull request with this backport targeting openjdk/jdk17u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e3dc6a7a from the openjdk/jdk repository.

The commit being backported was authored by Aggelos Biboudis on 9 Feb 2024 and was reviewed by Vicente Romero.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u:

$ git fetch https://github.com/openjdk-bots/jdk17u.git backport-biboudis-e3dc6a7a:backport-biboudis-e3dc6a7a
$ git checkout backport-biboudis-e3dc6a7a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u.git backport-biboudis-e3dc6a7a

⚠️ @biboudis You are not yet a collaborator in my fork openjdk-bots/jdk17u. An invite will be sent out and you need to accept it before you can proceed.

Please sign in to comment.