Skip to content

Commit e49232a

Browse files
committed
8254599: CDS dump should not warn about hidden classes
Reviewed-by: redestad, lfoltan, iklam
1 parent b464213 commit e49232a

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

src/hotspot/share/classfile/systemDictionaryShared.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1346,7 +1346,8 @@ bool SystemDictionaryShared::should_be_excluded(InstanceKlass* k) {
13461346
}
13471347

13481348
if (k->is_hidden() && !is_registered_lambda_proxy_class(k)) {
1349-
warn_excluded(k, "Hidden class");
1349+
ResourceMark rm;
1350+
log_debug(cds)("Skipping %s: %s", k->name()->as_C_string(), "Hidden class");
13501351
return true;
13511352
}
13521353

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdaCustomLoader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,15 @@ static void test() throws Exception {
4545
String mainClass = "CustomLoaderApp";
4646

4747
dump(topArchiveName,
48-
"-Xlog:class+load,cds,cds+dynamic",
48+
"-Xlog:class+load,cds=debug,cds+dynamic",
4949
"-cp", appJar, mainClass, appJar)
5050
.assertNormalExit(output -> {
5151
output.shouldMatch("Skipping.LambHello[$][$]Lambda[$].*0x.*:.Hidden.class")
5252
.shouldHaveExitValue(0);
5353
});
5454

5555
run(topArchiveName,
56-
"-Xlog:class+load,class+unload=info",
56+
"-Xlog:class+load,class+unload",
5757
"-cp", appJar, mainClass, appJar)
5858
.assertNormalExit(output -> {
5959
output.shouldMatch("class.load.*LambHello[$][$]Lambda[$].*0x.*source:.LambHello")

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdaProxyCallerIsHidden.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ static void test() throws Exception {
5353
String mainClass = "LambdaProxyCallerIsHiddenApp";
5454

5555
dump(topArchiveName,
56-
"-Xlog:class+load,cds+dynamic,cds",
56+
"-Xlog:class+load,cds+dynamic,cds=debug",
5757
"-cp", appJar, mainClass)
5858
.assertNormalExit(output -> {
5959
output.shouldMatch("Skipping.LambdaHello_0x.*[$][$]Lambda[$].*:.Hidden.class")

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/RegularHiddenClass.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ static void test() throws Exception {
5151
String mainClass = "InstantiateHiddenClass";
5252

5353
dump(topArchiveName,
54-
"-Xlog:class+load=debug,cds+dynamic,cds",
54+
"-Xlog:class+load=debug,cds+dynamic,cds=debug",
5555
"-cp", appJar, mainClass)
5656
.assertNormalExit(output -> {
5757
output.shouldMatch("cds.*Skipping.TestClass.0x.*Hidden.class")

0 commit comments

Comments
 (0)