Skip to content

Commit

Permalink
8286398: Address possibly lossy conversions in jdk.internal.le
Browse files Browse the repository at this point in the history 
Reviewed-by: jlahoda
  • Loading branch information
@asotona
asotona committed May 25, 2022
1 parent e21b527 commit e534c13
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions ...al.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/WindowsAnsiWriter.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -183,34 +183,34 @@ protected void processEraseLine(int eraseOption) throws IOException {
protected void processCursorUpLine(int count) throws IOException {
getConsoleInfo();
info.dwCursorPosition.X = 0;
info.dwCursorPosition.Y -= count;
info.dwCursorPosition.Y -= (short)count;
applyCursorPosition();
}

protected void processCursorDownLine(int count) throws IOException {
getConsoleInfo();
info.dwCursorPosition.X = 0;
info.dwCursorPosition.Y += count;
info.dwCursorPosition.Y += (short)count;
applyCursorPosition();
}

protected void processCursorLeft(int count) throws IOException {
getConsoleInfo();
info.dwCursorPosition.X -= count;
info.dwCursorPosition.X -= (short)count;
applyCursorPosition();
}

protected void processCursorRight(int count) throws IOException {
getConsoleInfo();
info.dwCursorPosition.X += count;
info.dwCursorPosition.X += (short)count;
applyCursorPosition();
}

protected void processCursorDown(int count) throws IOException {
getConsoleInfo();
int nb = Math.max(0, info.dwCursorPosition.Y + count - info.dwSize.Y + 1);
if (nb != count) {
info.dwCursorPosition.Y += count;
info.dwCursorPosition.Y += (short)count;
applyCursorPosition();
}
if (nb > 0) {
Expand All @@ -226,7 +226,7 @@ protected void processCursorDown(int count) throws IOException {

protected void processCursorUp(int count) throws IOException {
getConsoleInfo();
info.dwCursorPosition.Y -= count;
info.dwCursorPosition.Y -= (short)count;
applyCursorPosition();
}

Expand Down

5 comments on commit e534c13

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e534c13 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e534c13 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e534c13 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-e534c133 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e534c133 from the openjdk/jdk repository.

The commit being backported was authored by Adam Sotona on 25 May 2022 and was reviewed by Jan Lahoda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-e534c133:GoeLin-backport-e534c133
$ git checkout GoeLin-backport-e534c133
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-e534c133

@openjdk
Copy link

@openjdk openjdk bot commented on e534c13 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-e534c133 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e534c133 from the openjdk/jdk repository.

The commit being backported was authored by Adam Sotona on 25 May 2022 and was reviewed by Jan Lahoda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev.git GoeLin-backport-e534c133:GoeLin-backport-e534c133
$ git checkout GoeLin-backport-e534c133
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev.git GoeLin-backport-e534c133

Please sign in to comment.