Skip to content

Commit

Permalink
8316410: GC: Make TestCompressedClassFlags use createTestJvm
Browse files Browse the repository at this point in the history
Reviewed-by: ayang, mli
  • Loading branch information
lkorinth committed Oct 17, 2023
1 parent 5f4be8c commit e649c56
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/hotspot/jtreg/gc/arguments/TestCompressedClassFlags.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -35,6 +35,7 @@
* @library /
* @modules java.base/jdk.internal.misc
* java.management
* @requires vm.opt.CompressedClassSpaceSize == null & vm.opt.UseCompressedClassPointers == null
* @run driver gc.arguments.TestCompressedClassFlags
*/
public class TestCompressedClassFlags {
Expand All @@ -50,7 +51,7 @@ public static void main(String[] args) throws Exception {
}

private static OutputAnalyzer runJava(String ... args) throws Exception {
ProcessBuilder pb = GCArguments.createJavaProcessBuilder(args);
ProcessBuilder pb = GCArguments.createTestJvm(args);
return new OutputAnalyzer(pb.start());
}
}

5 comments on commit e649c56

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e649c56 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e649c56 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-e649c563 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e649c563 from the openjdk/jdk repository.

The commit being backported was authored by Leo Korinth on 17 Oct 2023 and was reviewed by Albert Mingkun Yang and Hamlin Li.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-e649c563:backport-GoeLin-e649c563
$ git checkout backport-GoeLin-e649c563
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-e649c563

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e649c56 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e649c56 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-e649c563-master in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e649c563 from the openjdk/jdk repository.

The commit being backported was authored by Leo Korinth on 17 Oct 2023 and was reviewed by Albert Mingkun Yang and Hamlin Li.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-GoeLin-e649c563-master:backport-GoeLin-e649c563-master
$ git checkout backport-GoeLin-e649c563-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-GoeLin-e649c563-master

Please sign in to comment.