Skip to content

Commit e93be3a

Browse files
rjernstChrisHegarty
authored andcommitted
8286389: Address possibly lossy conversions in jdk.crypto.ec
Reviewed-by: chegar, xuelei
1 parent 53b37fe commit e93be3a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPublicKeyImpl.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public final class XDHPublicKeyImpl extends X509Key implements XECPublicKey {
7676
// clear the extra bits
7777
int bitsMod8 = params.getBits() % 8;
7878
if (bitsMod8 != 0) {
79-
int mask = (1 << bitsMod8) - 1;
79+
byte mask = (byte) ((1 << bitsMod8) - 1);
8080
u_arr[0] &= mask;
8181
}
8282

src/jdk.crypto.ec/share/classes/sun/security/ec/ed/EdDSAOperations.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ private static void prune(byte[] k, int bits, int logCofactor) {
256256

257257
// set the highest bit
258258
if (highBits == 0) {
259-
k[lastByteIndex - 1] |= 0x80;
259+
k[lastByteIndex - 1] |= (byte) 0x80;
260260
} else {
261261
byte msbMaskOn = (byte) (1 << (highBits - 1));
262262
k[lastByteIndex] |= msbMaskOn;
@@ -278,7 +278,7 @@ private static byte[] encode(int length, Point p) {
278278
private static byte[] encode(int length, AffinePoint p) {
279279
byte[] result = p.getY().asByteArray(length);
280280
int xLSB = p.getX().asByteArray(1)[0] & 0x01;
281-
result[result.length - 1] |= (xLSB << 7);
281+
result[result.length - 1] |= (byte) (xLSB << 7);
282282
return result;
283283
}
284284
}

0 commit comments

Comments
 (0)