Skip to content

Commit

Permalink
8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg
Browse files Browse the repository at this point in the history
Reviewed-by: kevinw, cjplummer, dholmes
  • Loading branch information
jaikiran committed Jul 26, 2023
1 parent 117f42d commit e9daf4a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
3 changes: 1 addition & 2 deletions test/hotspot/jtreg/serviceability/attach/ShMemLongName.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -95,7 +95,6 @@ private static void log(String s) {
private static ProcessBuilder getTarget(String shmemName) throws IOException {
log("starting target with shmem name: '" + shmemName + "'...");
return ProcessTools.createJavaProcessBuilder(
"-Xdebug",
"-Xrunjdwp:transport=" + transport + ",server=y,suspend=n,address=" + shmemName,
"ShMemLongName$Target");
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -92,7 +92,6 @@ private static Process startDebuggee(String[] jdiArgs, String transport, String
Collections.addAll(cmd, Utils.prependTestJavaOpts(
"-cp",
Utils.TEST_CLASS_PATH,
"-Xdebug",
"-agentlib:jdwp=transport=" + transport + ",server=y,suspend=" + suspend,
"-Dmy.little.cookie=" + ProcessHandle.current().pid(),
debuggeeClass.getName()));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,6 @@ public String[] makeCommandLineArgs(String classToExecute, String transportAddre
args.add(classPath);
*/

args.add("-Xdebug");

String server;
if (argumentHandler.isAttachingConnector()) {
server = "y";
Expand Down

5 comments on commit e9daf4a

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e9daf4a Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e9daf4a Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-e9daf4a0 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e9daf4a0 from the openjdk/jdk repository.

The commit being backported was authored by Jaikiran Pai on 26 Jul 2023 and was reviewed by Kevin Walls, Chris Plummer and David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-e9daf4a0:backport-GoeLin-e9daf4a0
$ git checkout backport-GoeLin-e9daf4a0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-e9daf4a0

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e9daf4a Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e9daf4a Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-e9daf4a0 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e9daf4a0 from the openjdk/jdk repository.

The commit being backported was authored by Jaikiran Pai on 26 Jul 2023 and was reviewed by Kevin Walls, Chris Plummer and David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-GoeLin-e9daf4a0:backport-GoeLin-e9daf4a0
$ git checkout backport-GoeLin-e9daf4a0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-GoeLin-e9daf4a0

Please sign in to comment.