Skip to content

Commit

Permalink
8297450: ScaledTextFieldBorderTest.java fails when run with -show par…
Browse files Browse the repository at this point in the history
…ameter

Reviewed-by: aivanov, honkar
  • Loading branch information
rajamah authored and Harshitha Onkar committed Dec 6, 2022
1 parent 336d230 commit ea83cb9
Showing 1 changed file with 3 additions and 5 deletions.
Expand Up @@ -246,6 +246,8 @@ private static JComponent createUI() {
childPanel.add(Box.createHorizontalStrut(4));

contentPanel.add(childPanel);
contentPanel.add(Box.createVerticalStrut(4));

if (textFieldSize == null) {
textFieldSize = textField.getPreferredSize();
borderColor = tfBorder.getLineColor().getRGB();
Expand All @@ -254,18 +256,14 @@ private static JComponent createUI() {
textField.setBounds(i, 0, textFieldSize.width, textFieldSize.height);
childPanel.setBounds(0, (textFieldSize.height + 4) * i,
textFieldSize.width + i + 4, textFieldSize.height);
panelLocations.add(childPanel.getLocation());
}

contentPanel.setSize(textFieldSize.width + 4,
(textFieldSize.height + 4) * 4);

panelColor = contentPanel.getBackground().getRGB();

// Save coordinates of the panels
for (Component comp : contentPanel.getComponents()) {
panelLocations.add(comp.getLocation());
}

return contentPanel;
}

Expand Down

5 comments on commit ea83cb9

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on ea83cb9 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on ea83cb9 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-ea83cb96 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ea83cb96 from the openjdk/jdk repository.

The commit being backported was authored by Rajat Mahajan on 6 Dec 2022 and was reviewed by Alexey Ivanov and Harshitha Onkar.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-ea83cb96:GoeLin-backport-ea83cb96
$ git checkout GoeLin-backport-ea83cb96
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-ea83cb96

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on ea83cb9 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on ea83cb9 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-ea83cb96 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ea83cb96 from the openjdk/jdk repository.

The commit being backported was authored by Rajat Mahajan on 6 Dec 2022 and was reviewed by Alexey Ivanov and Harshitha Onkar.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev.git GoeLin-backport-ea83cb96:GoeLin-backport-ea83cb96
$ git checkout GoeLin-backport-ea83cb96
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev.git GoeLin-backport-ea83cb96

Please sign in to comment.