Skip to content
Permalink
Browse files
8254264: Remove redundant cross_modify_fence()
Reviewed-by: rehn, dholmes, dcubed
  • Loading branch information
pchilano committed Oct 20, 2020
1 parent 44f9271 commit f167a71f1dc5b7890c4fed7e84208b24315ac070
Showing with 0 additions and 5 deletions.
  1. +0 −2 src/hotspot/share/runtime/interfaceSupport.inline.hpp
  2. +0 −3 src/hotspot/share/runtime/thread.cpp
@@ -231,7 +231,6 @@ class ThreadBlockInVM : public ThreadStateTransition {
}
~ThreadBlockInVM() {
trans(_thread_blocked, _thread_in_vm);
OrderAccess::cross_modify_fence();
// We don't need to clear_walkable because it will happen automagically when we return to java
}
};
@@ -281,7 +280,6 @@ class ThreadBlockInVMWithDeadlockCheck : public ThreadStateTransition {
}

_thread->set_thread_state(_thread_in_vm);
OrderAccess::cross_modify_fence();
}
};

@@ -2605,9 +2605,6 @@ void JavaThread::java_suspend_self_with_safepoint_check() {
set_thread_state_fence(state);
} while (is_external_suspend());

// Since we are not using a regular thread-state transition helper here,
// we must manually emit the instruction barrier after leaving a safe state.
OrderAccess::cross_modify_fence();
if (state != _thread_in_native) {
SafepointMechanism::process_if_requested(this);
}

1 comment on commit f167a71

@bridgekeeper

This comment has been minimized.

Copy link

@bridgekeeper bridgekeeper bot commented on f167a71 Oct 20, 2020

Please sign in to comment.