Skip to content
Permalink
Browse files
8258908: Remove JVM option CleanChunkPoolAsync
Reviewed-by: coleenp
  • Loading branch information
Harold Seigel committed Jan 6, 2021
1 parent c0540ff commit f6cb8c558b03dcd7dfa4261406eac7317ed9ed53
Showing 6 changed files with 5 additions and 25 deletions.
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -864,10 +864,6 @@ void DefNewGeneration::gc_epilogue(bool full) {
to()->check_mangled_unused_area_complete();
}

if (!CleanChunkPoolAsync) {
Chunk::clean_chunk_pool();
}

// update the generation and space performance counters
update_counters();
gch->counters()->update_counters();
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -1267,10 +1267,6 @@ void GenCollectedHeap::gc_epilogue(bool full) {
GenGCEpilogueClosure blk(full);
generation_iterate(&blk, false); // not old-to-young.

if (!CleanChunkPoolAsync) {
Chunk::clean_chunk_pool();
}

MetaspaceCounters::update_performance_counters();
CompressedClassSpaceCounters::update_performance_counters();
};
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -154,11 +154,6 @@ void chunkpool_init() {
ChunkPool::initialize();
}

void
Chunk::clean_chunk_pool() {
ChunkPool::clean();
}


//--------------------------------------------------------------------------------------
// ChunkPoolCleaner implementation
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -85,8 +85,6 @@ class Chunk: CHeapObj<mtChunk> {

// Start the chunk_pool cleaner task
static void start_chunk_pool_cleaner_task();

static void clean_chunk_pool();
};

//------------------------------Arena------------------------------------------
@@ -167,9 +167,6 @@ const intx ObjectAlignmentInBytes = 8;
"region.") \
range(1, max_uintx) \
\
develop(bool, CleanChunkPoolAsync, true, \
"Clean the chunk pool asynchronously") \
\
product(uint, HandshakeTimeout, 0, DIAGNOSTIC, \
"If nonzero set a timeout in milliseconds for handshakes") \
\
@@ -3676,9 +3676,7 @@ jint Threads::create_vm(JavaVMInitArgs* args, bool* canTryAgain) {
create_vm_init_libraries();
}

if (CleanChunkPoolAsync) {
Chunk::start_chunk_pool_cleaner_task();
}
Chunk::start_chunk_pool_cleaner_task();

// Start the service thread
// The service thread enqueues JVMTI deferred events and does various hashtable

1 comment on commit f6cb8c5

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on f6cb8c5 Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.