Skip to content

Commit f7dee77

Browse files
committed
8301274: update for deprecated sprintf for security components
Reviewed-by: ascarpino
1 parent ec901f2 commit f7dee77

File tree

1 file changed

+5
-5
lines changed
  • src/jdk.crypto.mscapi/windows/native/libsunmscapi

1 file changed

+5
-5
lines changed

src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1223,17 +1223,17 @@ JNIEXPORT jboolean JNICALL Java_sun_security_mscapi_CSignature_verifyCngSignedHa
12231223

12241224
#define DUMP_PROP(p) \
12251225
if (::NCryptGetProperty(hKey, p, (PBYTE)buffer, 8192, &len, NCRYPT_SILENT_FLAG) == ERROR_SUCCESS) { \
1226-
sprintf(header, "%s %ls", #p, p); \
1226+
snprintf(header, sizeof(header), "%s %ls", #p, p); \
12271227
dump(header, buffer, len); \
12281228
}
12291229

12301230
#define EXPORT_BLOB(p) \
12311231
desc.cBuffers = 0; \
12321232
if (::NCryptExportKey(hKey, NULL, p, &desc, (PBYTE)buffer, 8192, &len, NCRYPT_SILENT_FLAG) == ERROR_SUCCESS) { \
1233-
sprintf(header, "%s %ls (%ld)", #p, p, desc.cBuffers); \
1233+
snprintf(header, sizeof(header), "%s %ls (%ld)", #p, p, desc.cBuffers); \
12341234
dump(header, buffer, len); \
12351235
for (int i = 0; i < (int)desc.cBuffers; i++) { \
1236-
sprintf(header, "desc %ld", desc.pBuffers[i].BufferType); \
1236+
snprintf(header, sizeof(header), "desc %ld", desc.pBuffers[i].BufferType); \
12371237
dump(header, (PBYTE)desc.pBuffers[i].pvBuffer, desc.pBuffers[i].cbBuffer); \
12381238
} \
12391239
}
@@ -1310,7 +1310,7 @@ void showProperty(NCRYPT_HANDLE hKey) {
13101310
bbd.pBuffers = &bb;
13111311
if(::NCryptExportKey(hKey, NULL, NCRYPT_PKCS8_PRIVATE_KEY_BLOB, NULL,
13121312
(PBYTE)buffer, 8192, &len, NCRYPT_SILENT_FLAG) == ERROR_SUCCESS) {
1313-
sprintf(header, "NCRYPT_PKCS8_PRIVATE_KEY_BLOB %ls", NCRYPT_PKCS8_PRIVATE_KEY_BLOB);
1313+
snprintf(header, sizeof(header), "NCRYPT_PKCS8_PRIVATE_KEY_BLOB %ls", NCRYPT_PKCS8_PRIVATE_KEY_BLOB);
13141314
dump(header, buffer, len);
13151315
}
13161316
EXPORT_BLOB(NCRYPT_PROTECTED_KEY_BLOB);
@@ -1445,7 +1445,7 @@ JNIEXPORT jstring JNICALL Java_sun_security_mscapi_CKey_getKeyType
14451445

14461446
} else {
14471447
char buffer[64];
1448-
if (sprintf(buffer, "%lu", dwAlgId)) {
1448+
if (snprintf(buffer, sizeof(buffer), "%lu", dwAlgId)) {
14491449
return env->NewStringUTF(buffer);
14501450
}
14511451
}

0 commit comments

Comments
 (0)