Skip to content

Commit f8b2574

Browse files
8296137: diags-examples.xml is broken
Reviewed-by: iris, vromero, ihse
1 parent 00d22f6 commit f8b2574

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

make/langtools/diags-examples.xml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,20 @@ Usage:
3535
By default, the reports will be generated in langtools/build/diags-examples/report/.
3636
-->
3737

38-
<project name="diags-examples" default="diags-examples" basedir="..">
38+
<project name="diags-examples" default="diags-examples" basedir="../..">
3939
<import file="build.xml"/>
4040

4141
<!-- specify working directory for the tool -->
4242
<property name="diags.examples.dir" location="${build.dir}/diag-examples"/>
4343

4444
<!-- compiled classes for the tool -->
45-
<property name="diags.examples.classes" location="${diags.examples.dir}/classes}"/>
45+
<property name="diags.examples.classes" location="${diags.examples.dir}/classes"/>
4646

4747
<!-- directory for generated reports -->
4848
<property name="diags.examples.report" location="${diags.examples.dir}/report"/>
4949

5050
<!-- default target, generates reports for all available locales -->
51-
<target name="diags-examples" depends="run-en_US,run-ja,run-zh_CN"/>
51+
<target name="diags-examples" depends="run-en_US,run-ja,run-zh_CN,run-de"/>
5252

5353
<!-- generate report for US English locale -->
5454
<target name="run-en_US" depends="-build-runner,-def-runner">
@@ -68,12 +68,18 @@ By default, the reports will be generated in langtools/build/diags-examples/repo
6868
<runner lang="zh" country="CN" outfile="${diags.examples.report}/zh_CN.html"/>
6969
</target>
7070

71+
<!-- generate report for German locale -->
72+
<target name="run-de" depends="-build-runner,-def-runner">
73+
<mkdir dir="${diags.examples.report}"/>
74+
<runner lang="de" outfile="${diags.examples.report}/de.html"/>
75+
</target>
76+
7177
<!-- compile the tool that runs the examples -->
7278
<target name="-build-runner" depends="build">
7379
<mkdir dir="${diags.examples.classes}"/>
7480
<javac fork="true"
7581
executable="${build.bin}/javac"
76-
srcdir="test/tools/javac/diags"
82+
srcdir="test/langtools/tools/javac/diags"
7783
destdir="${diags.examples.classes}"
7884
includes="ArgTypeCompilerFactory.java,Example.java,FileManager.java,HTMLWriter.java,RunExamples.java,DocCommentProcessor.java"
7985
sourcepath=""
@@ -98,7 +104,7 @@ By default, the reports will be generated in langtools/build/diags-examples/repo
98104
<sequential>
99105
<java fork="true"
100106
jvm="${langtools.jdk.home}/bin/java"
101-
dir="test/tools/javac/diags"
107+
dir="test/langtools/tools/javac/diags"
102108
classpath="${diags.examples.classes};${dist.lib.dir}/javac.jar;${dist.lib.dir}/javap.jar"
103109
classname="RunExamples">
104110
<jvmarg value="-Duser.language=@{lang}"/>

test/langtools/tools/javac/diags/Example.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ private void run(PrintWriter out, Set<String> keys, boolean raw, boolean verbose
234234
//automatic modules:
235235
Map<String, List<Path>> module2Files =
236236
modulePathFiles.stream()
237-
.map(f -> f.toPath())
237+
.map(f -> f.toPath().toAbsolutePath())
238238
.collect(Collectors.groupingBy(p -> modulePath.relativize(p)
239239
.getName(0)
240240
.toString()));

0 commit comments

Comments
 (0)