Skip to content

Commit f9bc2db

Browse files
committed
8325371: Missing ClassFile.Option in package summary
Reviewed-by: briangoetz
1 parent a8fbeec commit f9bc2db

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

src/java.base/share/classes/java/lang/classfile/ClassFile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ enum DeadCodeOption implements Option {
180180

181181
/**
182182
* Option describing whether to filter unresolved labels.
183-
* Default is {@code FAIL_ON_DEAD_LABELS} to throw IllegalStateException
183+
* Default is {@code FAIL_ON_DEAD_LABELS} to throw IllegalArgumentException
184184
* when any {@link ExceptionCatch}, {@link LocalVariableInfo},
185185
* {@link LocalVariableTypeInfo}, or {@link CharacterRangeInfo}
186186
* reference to unresolved {@link Label} during bytecode serialization.

src/java.base/share/classes/java/lang/classfile/package-info.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -174,20 +174,26 @@
174174
* for some statically enumerated options, as well as factories for more complex options,
175175
* including:
176176
* <ul>
177-
* <li>{@link java.lang.classfile.ClassFile.StackMapsOption}
178-
* -- generate stackmaps (default is {@code STACK_MAPS_WHEN_REQUIRED})</li>
179-
* <li>{@link java.lang.classfile.ClassFile.DebugElementsOption}
180-
* -- processing of debug information, such as local variable metadata (default is {@code PASS_DEBUG}) </li>
181-
* <li>{@link java.lang.classfile.ClassFile.LineNumbersOption}
182-
* -- processing of line numbers (default is {@code PASS_LINE_NUMBERS}) </li>
177+
* <li>{@link java.lang.classfile.ClassFile.AttributeMapperOption#of(java.util.function.Function)}
178+
* -- specify format of custom attributes</li>
183179
* <li>{@link java.lang.classfile.ClassFile.AttributesProcessingOption}
184180
* -- unrecognized or problematic original attributes (default is {@code PASS_ALL_ATTRIBUTES})</li>
185-
* <li>{@link java.lang.classfile.ClassFile.ConstantPoolSharingOption}}
186-
* -- share constant pool when transforming (default is {@code SHARED_POOL})</li>
187181
* <li>{@link java.lang.classfile.ClassFile.ClassHierarchyResolverOption#of(java.lang.classfile.ClassHierarchyResolver)}
188182
* -- specify a custom class hierarchy resolver used by stack map generation</li>
189-
* <li>{@link java.lang.classfile.ClassFile.AttributeMapperOption#of(java.util.function.Function)}
190-
* -- specify format of custom attributes</li>
183+
* <li>{@link java.lang.classfile.ClassFile.ConstantPoolSharingOption}}
184+
* -- share constant pool when transforming (default is {@code SHARED_POOL})</li>
185+
* <li>{@link java.lang.classfile.ClassFile.DeadCodeOption}}
186+
* -- patch out unreachable code (default is {@code PATCH_DEAD_CODE})</li>
187+
* <li>{@link java.lang.classfile.ClassFile.DeadLabelsOption}}
188+
* -- filter unresolved labels (default is {@code FAIL_ON_DEAD_LABELS})</li>
189+
* <li>{@link java.lang.classfile.ClassFile.DebugElementsOption}
190+
* -- processing of debug information, such as local variable metadata (default is {@code PASS_DEBUG}) </li>
191+
* <li>{@link java.lang.classfile.ClassFile.LineNumbersOption}
192+
* -- processing of line numbers (default is {@code PASS_LINE_NUMBERS}) </li>
193+
* <li>{@link java.lang.classfile.ClassFile.ShortJumpsOption}
194+
* -- automatically rewrite short jumps to long when necessary (default is {@code FIX_SHORT_JUMPS})</li>
195+
* <li>{@link java.lang.classfile.ClassFile.StackMapsOption}
196+
* -- generate stackmaps (default is {@code STACK_MAPS_WHEN_REQUIRED})</li>
191197
* </ul>
192198
* <p>
193199
* Most options allow you to request that certain parts of the classfile be

0 commit comments

Comments
 (0)