Skip to content

Commit

Permalink
8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed …
Browse files Browse the repository at this point in the history 
…due to SocketTimeoutException

Reviewed-by: lmesnik, amenkov, sspitsyn
  • Loading branch information
@plummercj
plummercj committed Mar 29, 2022
1 parent 9591306 commit f9f439a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2001, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2001, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -151,6 +151,8 @@ public static int run(final String args[], final PrintStream out) {
if (checkedRequest != null) {
log.display("Disabling event request");
checkedRequest.disable();
// need to resume all threads in case a stray ThreadStartEvent arrived
vm.resume();
}

// force debuggee to quit
Expand Down

5 comments on commit f9f439a

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on f9f439a Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on f9f439a Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-f9f439a1 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f9f439a1 from the openjdk/jdk repository.

The commit being backported was authored by Chris Plummer on 29 Mar 2022 and was reviewed by Leonid Mesnik, Alex Menkov and Serguei Spitsyn.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-f9f439a1:GoeLin-backport-f9f439a1
$ git checkout GoeLin-backport-f9f439a1
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-f9f439a1

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on f9f439a Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on f9f439a Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-f9f439a1 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f9f439a1 from the openjdk/jdk repository.

The commit being backported was authored by Chris Plummer on 29 Mar 2022 and was reviewed by Leonid Mesnik, Alex Menkov and Serguei Spitsyn.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-f9f439a1:GoeLin-backport-f9f439a1
$ git checkout GoeLin-backport-f9f439a1
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-f9f439a1

Please sign in to comment.