Skip to content

Commit faa6b66

Browse files
committed
8295715: Minimize disabled warnings in serviceability libs
Reviewed-by: cjplummer, erikj
1 parent de1e0c5 commit faa6b66

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

make/modules/java.instrument/Lib.gmk

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2011, 2020, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -39,7 +39,6 @@ $(eval $(call SetupJdkLibrary, BUILD_LIBINSTRUMENT, \
3939
CFLAGS := $(CFLAGS_JDKLIB) $(LIBINSTRUMENT_CFLAGS), \
4040
CFLAGS_debug := -DJPLIS_LOGGING, \
4141
CFLAGS_release := -DNO_JPLIS_LOGGING, \
42-
DISABLED_WARNINGS_gcc := unused-function, \
4342
EXTRA_HEADER_DIRS := java.base:libjli, \
4443
LDFLAGS := $(LDFLAGS_JDKLIB) \
4544
$(call SET_SHARED_LIBRARY_ORIGIN) \

make/modules/jdk.hotspot.agent/Lib.gmk

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -59,9 +59,11 @@ $(eval $(call SetupJdkLibrary, BUILD_LIBSA, \
5959
NAME := saproc, \
6060
TOOLCHAIN := $(SA_TOOLCHAIN), \
6161
OPTIMIZATION := HIGH, \
62-
DISABLED_WARNINGS_microsoft := 4267, \
63-
DISABLED_WARNINGS_gcc := sign-compare pointer-arith, \
64-
DISABLED_WARNINGS_clang := sign-compare pointer-arith format-nonliteral, \
62+
DISABLED_WARNINGS_gcc := sign-compare, \
63+
DISABLED_WARNINGS_gcc_ps_core.c := pointer-arith, \
64+
DISABLED_WARNINGS_clang := sign-compare, \
65+
DISABLED_WARNINGS_clang_libproc_impl.c := format-nonliteral, \
66+
DISABLED_WARNINGS_clang_sadis.c := format-nonliteral, \
6567
CFLAGS := $(CFLAGS_JDKLIB) $(SA_CFLAGS), \
6668
CXXFLAGS := $(CXXFLAGS_JDKLIB) $(SA_CFLAGS) $(SA_CXXFLAGS), \
6769
EXTRA_SRC := $(LIBSA_EXTRA_SRC), \

make/modules/jdk.jdwp.agent/Lib.gmk

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2011, 2020, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -52,9 +52,11 @@ $(eval $(call SetupJdkLibrary, BUILD_LIBJDWP, \
5252
NAME := jdwp, \
5353
OPTIMIZATION := LOW, \
5454
CFLAGS := $(CFLAGS_JDKLIB) -DJDWP_LOGGING, \
55-
DISABLED_WARNINGS_gcc := unused-function, \
56-
DISABLED_WARNINGS_clang := sometimes-uninitialized format-nonliteral \
57-
self-assign, \
55+
DISABLED_WARNINGS_gcc_SDE.c := unused-function, \
56+
DISABLED_WARNINGS_clang_error_messages.c := format-nonliteral, \
57+
DISABLED_WARNINGS_clang_EventRequestImpl.c := self-assign, \
58+
DISABLED_WARNINGS_clang_inStream.c := sometimes-uninitialized, \
59+
DISABLED_WARNINGS_clang_log_messages.c := format-nonliteral, \
5860
EXTRA_HEADER_DIRS := \
5961
include \
6062
libjdwp/export, \

make/modules/jdk.management/Lib.gmk

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -45,7 +45,6 @@ $(eval $(call SetupJdkLibrary, BUILD_LIBMANAGEMENT_EXT, \
4545
NAME := management_ext, \
4646
OPTIMIZATION := $(LIBMANAGEMENT_EXT_OPTIMIZATION), \
4747
CFLAGS := $(CFLAGS_JDKLIB) $(LIBMANAGEMENT_EXT_CFLAGS), \
48-
DISABLED_WARNINGS_clang := format-nonliteral, \
4948
LDFLAGS := $(LDFLAGS_JDKLIB) \
5049
$(call SET_SHARED_LIBRARY_ORIGIN), \
5150
LIBS := $(JDKLIB_LIBS), \

0 commit comments

Comments
 (0)