Skip to content

Commit fafe682

Browse files
committed
8295861: get rid of list argument in debug agent's removeNode() API
Reviewed-by: amenkov, kevinw, sspitsyn
1 parent 216c6f6 commit fafe682

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c

+6-6
Original file line numberDiff line numberDiff line change
@@ -290,14 +290,14 @@ findRunningThread(jthread thread)
290290

291291
/* Remove a ThreadNode from a ThreadList */
292292
static void
293-
removeNode(ThreadList *list, ThreadNode *node)
293+
removeNode(ThreadNode *node)
294294
{
295295
ThreadNode *prev;
296296
ThreadNode *next;
297-
298-
JDI_ASSERT(list == node->list);
297+
ThreadList *list;
299298
prev = node->prev;
300299
next = node->next;
300+
list = node->list;
301301
if ( prev != NULL ) {
302302
prev->next = next;
303303
}
@@ -467,7 +467,7 @@ static void
467467
removeThread(JNIEnv *env, ThreadNode *node)
468468
{
469469
JDI_ASSERT(node != NULL);
470-
removeNode(node->list, node);
470+
removeNode(node);
471471
clearThread(env, node);
472472
}
473473

@@ -493,7 +493,7 @@ removeVThreads(JNIEnv *env)
493493
ThreadNode *node = list->first;
494494
while (node != NULL) {
495495
ThreadNode *temp = node->next;
496-
removeNode(list, node);
496+
removeNode(node);
497497
clearThread(env, node);
498498
node = temp;
499499
}
@@ -502,7 +502,7 @@ removeVThreads(JNIEnv *env)
502502
static void
503503
moveNode(ThreadList *source, ThreadList *dest, ThreadNode *node)
504504
{
505-
removeNode(source, node);
505+
removeNode(node);
506506
JDI_ASSERT(findThread(dest, node->thread) == NULL);
507507
addNode(dest, node);
508508
}

0 commit comments

Comments
 (0)