Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit 
Reviewed-by: shade
  • Loading branch information
@sormuras @shipilev
sormuras authored and shipilev committed Nov 8, 2021
1 parent 3934fe5 commit fc0fe25
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/jdk/tools/launcher/HelpFlagsTest.java
View file
Expand Up @@ -47,7 +47,9 @@ public class HelpFlagsTest extends TestHelper {
static final String[] TOOLS_NOT_TO_TEST = {
"appletviewer", // deprecated, don't test
"jaccessinspector", // gui, don't test, win only
"jaccessinspector-32", // gui, don't test, win-32 only
"jaccesswalker", // gui, don't test, win only
"jaccesswalker-32", // gui, don't test, win-32 only
"jconsole", // gui, don't test
"servertool", // none. Shell, don't test.
"javaw", // don't test, win only
Expand Down

7 comments on commit fc0fe25

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@adamfarley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u

@adamfarley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u

@openjdk
Copy link

@openjdk openjdk bot commented on fc0fe25 Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamfarley @adamfarley the backport was successfully created on the branch adamfarley-backport-fc0fe256 in my personal fork of openjdk/jdk17u. To create a pull request with this backport targeting openjdk/jdk17u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit fc0fe256 from the openjdk/jdk repository.

The commit being backported was authored by Christian Stein on 8 Nov 2021 and was reviewed by Aleksey Shipilev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u:

$ git fetch https://github.com/openjdk-bots/jdk17u adamfarley-backport-fc0fe256:adamfarley-backport-fc0fe256
$ git checkout adamfarley-backport-fc0fe256
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u adamfarley-backport-fc0fe256

@openjdk
Copy link

@openjdk openjdk bot commented on fc0fe25 Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamfarley @adamfarley the backport was successfully created on the branch adamfarley-backport-fc0fe256 in my personal fork of openjdk/jdk11u. To create a pull request with this backport targeting openjdk/jdk11u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit fc0fe256 from the openjdk/jdk repository.

The commit being backported was authored by Christian Stein on 8 Nov 2021 and was reviewed by Aleksey Shipilev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u:

$ git fetch https://github.com/openjdk-bots/jdk11u adamfarley-backport-fc0fe256:adamfarley-backport-fc0fe256
$ git checkout adamfarley-backport-fc0fe256
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u adamfarley-backport-fc0fe256

@adamfarley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on fc0fe25 Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamfarley @adamfarley the backport was successfully created on the branch adamfarley-backport-fc0fe256 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit fc0fe256 from the openjdk/jdk repository.

The commit being backported was authored by Christian Stein on 8 Nov 2021 and was reviewed by Aleksey Shipilev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev adamfarley-backport-fc0fe256:adamfarley-backport-fc0fe256
$ git checkout adamfarley-backport-fc0fe256
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev adamfarley-backport-fc0fe256

Please sign in to comment.