JDK-8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures

[MBaesken]

https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-multibytetowidechar
states about MultiByteToWideChar : "The function returns 0 if it does not succeed" and lists a few failure cases.
However we miss checking the failure case in Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation , seems we assume the function always works nicely (in most of the JDK coding the return value is checked ).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10015/head:pull/10015
$ git checkout pull/10015

Update a local copy of the PR:
$ git checkout pull/10015
$ git pull https://git.openjdk.org/jdk pull/10015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10015

View PR using the GUI difftool:
$ git pr show -t 10015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10015.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (35960e95)
• 00: Full (e4e71ef7)

[MBaesken]

I adjusted the return syntax.

[MBaesken]

Hi Phil are you fine with the latest revision?

[TheRealMDoerr]

This version LGTM.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures

Reviewed-by: mdoerr, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 195 new commits pushed to the master branch:

• 68da02c: 8292240: CarrierThread.blocking not reset when spare not activated
• 005b49b: 8293044: C1: Missing access check on non-accessible class
• 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
• 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
• dbec22b: 8293287: add ReplayReduce flag
• b8598b0: 8291660: Grapheme support in BreakIterator
• a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite
• 00befdd: 8292675: Add identity transformation for removing redundant AndV/OrV nodes
• 7169ee5: 8293477: IGV: Upgrade to Netbeans Platform 15
• 3dd94f3: 8292671: Hotspot Style Guide should allow covariant returns
• ... and 185 more: https://git.openjdk.org/jdk/compare/5a20bc44b1fb4edb6ab714191cdc6c3f33ac9836...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

LGTM

[MBaesken]

Hi , thanks for the reviews !

[MBaesken]

/integrate

[openjdk]

Going to push as commit 699c429.
Since your change was applied there have been 195 commits pushed to the master branch:

• 68da02c: 8292240: CarrierThread.blocking not reset when spare not activated
• 005b49b: 8293044: C1: Missing access check on non-accessible class
• 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
• 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
• dbec22b: 8293287: add ReplayReduce flag
• b8598b0: 8291660: Grapheme support in BreakIterator
• a14c3a4: 8288933: Improve the implementation of Double/Float.isInfinite
• 00befdd: 8292675: Add identity transformation for removing redundant AndV/OrV nodes
• 7169ee5: 8293477: IGV: Upgrade to Netbeans Platform 15
• 3dd94f3: 8292671: Hotspot Style Guide should allow covariant returns
• ... and 185 more: https://git.openjdk.org/jdk/compare/5a20bc44b1fb4edb6ab714191cdc6c3f33ac9836...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 699c429.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.