-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8292903: enhance round_up_power_of_2 assertion output #10016
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Hi Stefan and Thomas, thanks for the reviews. |
/integrate |
There is an assertion in round_up_power_of_2 for value <= max_power_of_2 of the type; would be nice to show the value of the problematic argument in case of failures.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10016/head:pull/10016
$ git checkout pull/10016
Update a local copy of the PR:
$ git checkout pull/10016
$ git pull https://git.openjdk.org/jdk pull/10016/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10016
View PR using the GUI difftool:
$ git pr show -t 10016
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10016.diff