Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8292903: enhance round_up_power_of_2 assertion output #10016

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 25, 2022

There is an assertion in round_up_power_of_2 for value <= max_power_of_2 of the type; would be nice to show the value of the problematic argument in case of failures.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292903: enhance round_up_power_of_2 assertion output

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10016/head:pull/10016
$ git checkout pull/10016

Update a local copy of the PR:
$ git checkout pull/10016
$ git pull https://git.openjdk.org/jdk pull/10016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10016

View PR using the GUI difftool:
$ git pr show -t 10016

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10016.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 25, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292903: enhance round_up_power_of_2 assertion output

Reviewed-by: stefank, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 054c23f: 8290025: Remove the Sweeper
  • dc7e256: 8290376: G1: Refactor G1MMUTracker::when_sec

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2022
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@MBaesken
Copy link
Member Author

Hi Stefan and Thomas, thanks for the reviews.

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2022

Going to push as commit 8d3d439.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 054c23f: 8290025: Remove the Sweeper
  • dc7e256: 8290376: G1: Refactor G1MMUTracker::when_sec

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2022
@openjdk openjdk bot closed this Aug 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@MBaesken Pushed as commit 8d3d439.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants