Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292910: Remove root to oop cast in HeapDumper #10018

Conversation

stefank
Copy link
Member

@stefank stefank commented Aug 25, 2022

Small cleanup to fix an unclean cast. This patch was brought over from the Generational ZGC repository, where we have extra verification code around casts to oops.

I deduplicated the pointer dumping implementation, instead of adding a third version looking more or less the same.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10018/head:pull/10018
$ git checkout pull/10018

Update a local copy of the PR:
$ git checkout pull/10018
$ git pull https://git.openjdk.org/jdk pull/10018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10018

View PR using the GUI difftool:
$ git pr show -t 10018

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10018.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2022

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@stefank The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 25, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2022

Webrevs

Copy link
Contributor

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292910: Remove root to oop cast in HeapDumper

Reviewed-by: eosterlund, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

  • 054c23f: 8290025: Remove the Sweeper
  • dc7e256: 8290376: G1: Refactor G1MMUTracker::when_sec
  • 5a20bc4: 8292715: Cleanup Problemlist
  • 7b81a9c: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • 76ee549: 8292329: Enable CDS shared heap for zero builds
  • 14623c6: 8292739: Invalid legacy entries may be returned by Provider.getServices() call
  • 568be58: 8290469: Add new positioning options to PassFailJFrame test framework
  • 69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
  • 3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
  • 71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
  • ... and 121 more: https://git.openjdk.org/jdk/compare/fd4b2f2868ac6eaf192b50db5c5adc76e0d54308...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2022
@stefank
Copy link
Member Author

stefank commented Aug 26, 2022

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2022

Going to push as commit 4732abf.
Since your change was applied there have been 147 commits pushed to the master branch:

  • f694f8a: 8292083: Detected container memory limit may exceed physical machine memory
  • f91943c: 8292868: Explicitly pass a third temp register to MacroAssembler::store_heap_oop for aarch64
  • 6354a57: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 3e18773: 8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java
  • 909e1ed: 8292919: Build failure due to UseJVMCICompiler was not declared when C2 is disabled after JDK-8292691
  • 55f5a83: 8282410: Remove SA ProcDebugger support
  • d83faea: 8292250: Create test for co-located JDI MethodEntry, Step, and Breakpoint events
  • e353b57: 8292890: Remove PrintTouchedMethodsAtExit and LogTouchedMethods
  • 95a33fe: 8292314: Cleanup legacy address handling
  • 5d799d8: 8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS
  • ... and 137 more: https://git.openjdk.org/jdk/compare/fd4b2f2868ac6eaf192b50db5c5adc76e0d54308...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2022
@openjdk openjdk bot closed this Aug 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@stefank Pushed as commit 4732abf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants