-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292694: x86_64 c2i/i2c adapters may use more stack space than necessary #10034
Conversation
👋 Welcome back dlong! A progress list of the required criteria for merging this PR into |
/cc hotspot-compiler hotspot-runtime hotspot |
@dean-long The The |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@dean-long This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks Vladimir. |
I included generate_Continuation_doYield_entry() changes by mistake. I will revert those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was wandering about generate_Continuation_doYield_entry().
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks Tobias. |
/integrate |
Going to push as commit adb3d4f.
Your commit was automatically rebased without conflicts. |
@dean-long Pushed as commit adb3d4f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The c2i adapter includes the return address in the alignment calculation, making %rsp always mis-aligned according to the ABI.
The i2c adapter aligns "extrawords" even though %rsp is aligned later, and the incoming stack is not guaranteed to be aligned.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10034/head:pull/10034
$ git checkout pull/10034
Update a local copy of the PR:
$ git checkout pull/10034
$ git pull https://git.openjdk.org/jdk pull/10034/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10034
View PR using the GUI difftool:
$ git pr show -t 10034
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10034.diff