-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant. #10039
Conversation
…thod non-entrant without deoptimizing current activations
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
Webrevs
|
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit b0e0b87.
Your commit was automatically rebased without conflicts. |
The existing
InstalledCode.invalidate()
method not only makes the underlying nmethod non-entrant but also immediately deoptimizes all current activations of the nmethod.In some scenarios, it's useful to be able to make the nmethod non-entrant but let existing activations complete. For example, which installing new code in Truffle tiered compilation.
This PR adds
InstalledCode.invalidate(boolean deoptimize)
for that purpose.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10039/head:pull/10039
$ git checkout pull/10039
Update a local copy of the PR:
$ git checkout pull/10039
$ git pull https://git.openjdk.org/jdk pull/10039/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10039
View PR using the GUI difftool:
$ git pr show -t 10039
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10039.diff