Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant. #10039

Closed
wants to merge 2 commits into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Aug 26, 2022

The existing InstalledCode.invalidate() method not only makes the underlying nmethod non-entrant but also immediately deoptimizes all current activations of the nmethod.
In some scenarios, it's useful to be able to make the nmethod non-entrant but let existing activations complete. For example, which installing new code in Truffle tiered compilation.
This PR adds InstalledCode.invalidate(boolean deoptimize) for that purpose.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10039/head:pull/10039
$ git checkout pull/10039

Update a local copy of the PR:
$ git checkout pull/10039
$ git pull https://git.openjdk.org/jdk pull/10039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10039

View PR using the GUI difftool:
$ git pr show -t 10039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10039.diff

…thod non-entrant without deoptimizing current activations
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@dougxc The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 26, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant.

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
  • 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
  • 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
  • 3844685: 8292697: ZGC: Hangs when almost out of metaspace memory
  • 2b80349: 8292669: IGV: Search not useable when in Overflow Toolbar
  • 4732abf: 8292910: Remove root to oop cast in HeapDumper
  • f694f8a: 8292083: Detected container memory limit may exceed physical machine memory
  • f91943c: 8292868: Explicitly pass a third temp register to MacroAssembler::store_heap_oop for aarch64
  • 6354a57: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 26, 2022
@dougxc
Copy link
Member Author

dougxc commented Aug 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 27, 2022

Going to push as commit b0e0b87.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 1500d3d: 8292994: ProblemList vmTestbase/gc/lock/jni/jnilock001/TestDescription.java
  • 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
  • 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
  • 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
  • 3844685: 8292697: ZGC: Hangs when almost out of metaspace memory
  • 2b80349: 8292669: IGV: Search not useable when in Overflow Toolbar
  • 4732abf: 8292910: Remove root to oop cast in HeapDumper
  • f694f8a: 8292083: Detected container memory limit may exceed physical machine memory
  • f91943c: 8292868: Explicitly pass a third temp register to MacroAssembler::store_heap_oop for aarch64
  • ... and 1 more: https://git.openjdk.org/jdk/compare/3e187730162965981a5e6d238935e46d1015708e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 27, 2022
@openjdk openjdk bot closed this Aug 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 27, 2022
@openjdk
Copy link

openjdk bot commented Aug 27, 2022

@dougxc Pushed as commit b0e0b87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc dougxc deleted the JDK-8292917 branch May 23, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants