8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks

[shipilev]

Look at implementation and figure out what happens if you do:

 computeHash("SHA-1") = someHash;
 computeHash("SHA-256") = ...?

The caching method should actually check the algorithms match.

Not a bug at this point, since only use SHA-256 today, but this is a landmine ready to fire.

Additional testing:

• Linux x86_64 release, java/lang/module tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Mandy Chung (@mlchung - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10044/head:pull/10044
$ git checkout pull/10044

Update a local copy of the PR:
$ git checkout pull/10044
$ git pull https://git.openjdk.org/jdk pull/10044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10044

View PR using the GUI difftool:
$ git pr show -t 10044

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10044.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (f3eb926d)
• 02: Full - Incremental (4cd7399e)
• 01: Full - Incremental (03961f29)
• 00: Full (40f76f5b)

[AlanBateman]

Can you make sure that you run all jar, jmod and jlink tests? Module hashes are generated at packaging time, then checked when generating the configuration in early startup.

[shipilev]

Can you make sure that you run all jar, jmod and jlink tests? Module hashes are generated at packaging time, then checked when generating the configuration in early startup.

java/util/jar, jdk/tools/jmod, jdk/tools/jlink -- all fine on Linux x86_64 release.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks

Reviewed-by: alanb, mchung, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 1500d3d: 8292994: ProblemList vmTestbase/gc/lock/jni/jnilock001/TestDescription.java
• 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
• 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
• 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
• c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
• 3844685: 8292697: ZGC: Hangs when almost out of metaspace memory
• 2b80349: 8292669: IGV: Search not useable when in Overflow Toolbar
• 4732abf: 8292910: Remove root to oop cast in HeapDumper
• f694f8a: 8292083: Detected container memory limit may exceed physical machine memory
• f91943c: 8292868: Explicitly pass a third temp register to MacroAssembler::store_heap_oop for aarch64
• ... and 10 more: https://git.openjdk.org/jdk/compare/251bff6beeafcd98824dab60e9831c0175fe0689...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlchung]

Looks good to me.

[shipilev]

Thank you all.

/integrate

[openjdk]

Going to push as commit a476ec5.
Since your change was applied there have been 23 commits pushed to the master branch:

• 99cab6a: 8292911: Add a note about jtreg failure handlers in the testing doc
• f6b6360: 8289949: Improve test coverage for XPath: operators
• b0e0b87: 8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant.
• 1500d3d: 8292994: ProblemList vmTestbase/gc/lock/jni/jnilock001/TestDescription.java
• 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
• 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
• 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
• c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
• 3844685: 8292697: ZGC: Hangs when almost out of metaspace memory
• 2b80349: 8292669: IGV: Search not useable when in Overflow Toolbar
• ... and 13 more: https://git.openjdk.org/jdk/compare/251bff6beeafcd98824dab60e9831c0175fe0689...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit a476ec5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.