Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8289949 Improve test coverage for XPath: operators #10047

Closed
wants to merge 2 commits into from

Conversation

bwhuang-us
Copy link
Contributor

@bwhuang-us bwhuang-us commented Aug 26, 2022

Provided coverage for XPath operators. Operators include:

  • Boolean operators: or, and, =, !=, <, <=, >, >=
  • Number operators: +, -, *, div, mod
  • Union operator: |

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289949: Improve test coverage for XPath: operators

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10047/head:pull/10047
$ git checkout pull/10047

Update a local copy of the PR:
$ git checkout pull/10047
$ git pull https://git.openjdk.org/jdk pull/10047/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10047

View PR using the GUI difftool:
$ git pr show -t 10047

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10047.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

👋 Welcome back bwhuang-us! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@bwhuang-us The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 26, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2022

Webrevs

Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few minor comments below.

@DataProvider(name = "operatorExpTestCases")
public Object[][] getOperatorExp() {
return new Object[][]{
// boolean operators: or, and, =, !=, <, <=, >, >=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boolean and relational operators

{"count(//Customer[Age >= 0 and Age <= 0])", 1.0},
{"count(//Customer[Age >= 0][Age <= 0])", 1.0},
{"count(//Customer[Age > 0 or Age < 0])", 2.0},
{"count(//Customer[Age != 0])", 2.0},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better for 'count' to return an integer.

{"count(//Customer[Age > 0 or Age < 0])", 2.0},
{"count(//Customer[Age != 0])", 2.0},

// number operators: +, -, *, div, mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arithmetic operators

Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@bwhuang-us This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289949: Improve test coverage for XPath: operators

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 1500d3d: 8292994: ProblemList vmTestbase/gc/lock/jni/jnilock001/TestDescription.java
  • 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
  • 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
  • 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
  • 3844685: 8292697: ZGC: Hangs when almost out of metaspace memory
  • 2b80349: 8292669: IGV: Search not useable when in Overflow Toolbar
  • 4732abf: 8292910: Remove root to oop cast in HeapDumper
  • f694f8a: 8292083: Detected container memory limit may exceed physical machine memory
  • f91943c: 8292868: Explicitly pass a third temp register to MacroAssembler::store_heap_oop for aarch64
  • ... and 20 more: https://git.openjdk.org/jdk/compare/568be58e8521e5e87baca1872ba8cc1941607bb7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JoeWang-Java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 26, 2022
@bwhuang-us
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@bwhuang-us
Your change (at version fb25247) is now ready to be sponsored by a Committer.

@JoeWang-Java
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 28, 2022

Going to push as commit f6b6360.
Since your change was applied there have been 31 commits pushed to the master branch:

  • b0e0b87: 8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant.
  • 1500d3d: 8292994: ProblemList vmTestbase/gc/lock/jni/jnilock001/TestDescription.java
  • 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
  • 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
  • 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
  • 3844685: 8292697: ZGC: Hangs when almost out of metaspace memory
  • 2b80349: 8292669: IGV: Search not useable when in Overflow Toolbar
  • 4732abf: 8292910: Remove root to oop cast in HeapDumper
  • f694f8a: 8292083: Detected container memory limit may exceed physical machine memory
  • ... and 21 more: https://git.openjdk.org/jdk/compare/568be58e8521e5e87baca1872ba8cc1941607bb7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2022
@openjdk openjdk bot closed this Aug 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 28, 2022
@openjdk
Copy link

openjdk bot commented Aug 28, 2022

@JoeWang-Java @bwhuang-us Pushed as commit f6b6360.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bwhuang-us bwhuang-us deleted the JDK-8289949 branch March 1, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants