Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292383: Create a SymbolHandle type to use for ResourceHashtable #10052

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Aug 26, 2022

This change creates a SymbolHandle which shares code with TempNewSymbol and moves them to their own header file. We could expand this use if needed for GrowableArrays and other things where we have some various Symbol increment/decrement refcounts now. Changed a few ResourceHashtables that take Symbol* keys to use SymbolHandle and verified the refcounts. Also fixed the gtest.
Tested with tier1-7.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292383: Create a SymbolHandle type to use for ResourceHashtable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10052/head:pull/10052
$ git checkout pull/10052

Update a local copy of the PR:
$ git checkout pull/10052
$ git pull https://git.openjdk.org/jdk pull/10052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10052

View PR using the GUI difftool:
$ git pr show -t 10052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10052.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 26, 2022
@coleenp coleenp changed the title 8292383: Create a SymbolKey type to use for ResourceHashtable 8292383: Create a SymbolHandle type to use for ResourceHashtable Sep 2, 2022
@coleenp coleenp marked this pull request as ready for review September 6, 2022 16:34
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2022

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a nice clean up.

@openjdk
Copy link

openjdk bot commented Sep 6, 2022

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292383: Create a SymbolHandle type to use for ResourceHashtable

Reviewed-by: iklam, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 6ff4775: 8285487: AArch64: Do not generate unneeded trampolines for runtime calls
  • d696104: 4850101: Setting mnemonic to VK_F4 underlines the letter S in a button.
  • 14fd1b6: 8292921: Rewrite object field printer
  • 4f9065d: 8293333: Broken links in JDI specification
  • 2259e42: 8293197: Avoid double racy reads from non-volatile fields in SharedSecrets
  • 205f992: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
  • 710a143: 8293445: clhsdb "thread" command gives incorrect error message for bad threadID
  • 57930f8: 8293285: x86_64: Move libm stub implementations to StubGenerator
  • 5b4c415: 8293254: x86_64: Extract arraycopy stub implementations into a separate file
  • fb6eb6f: 8293245: x86_64: Extract Adler32 stub implementation into stubGenerator_x86_64_adler.cpp
  • ... and 4 more: https://git.openjdk.org/jdk/compare/c05015bc93916303ff1f16dec5d9391d2d773f41...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2022
@coleenp
Copy link
Contributor Author

coleenp commented Sep 6, 2022

Thanks Ioi!

Copy link
Member

@hseigel hseigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coleenp
Copy link
Contributor Author

coleenp commented Sep 7, 2022

Thanks Harold!
/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

Going to push as commit 5934669.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 6ff4775: 8285487: AArch64: Do not generate unneeded trampolines for runtime calls
  • d696104: 4850101: Setting mnemonic to VK_F4 underlines the letter S in a button.
  • 14fd1b6: 8292921: Rewrite object field printer
  • 4f9065d: 8293333: Broken links in JDI specification
  • 2259e42: 8293197: Avoid double racy reads from non-volatile fields in SharedSecrets
  • 205f992: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
  • 710a143: 8293445: clhsdb "thread" command gives incorrect error message for bad threadID
  • 57930f8: 8293285: x86_64: Move libm stub implementations to StubGenerator
  • 5b4c415: 8293254: x86_64: Extract arraycopy stub implementations into a separate file
  • fb6eb6f: 8293245: x86_64: Extract Adler32 stub implementation into stubGenerator_x86_64_adler.cpp
  • ... and 4 more: https://git.openjdk.org/jdk/compare/c05015bc93916303ff1f16dec5d9391d2d773f41...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2022
@openjdk openjdk bot closed this Sep 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@coleenp Pushed as commit 5934669.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the symbolkey branch September 7, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants