8293023: Change CardTable::is_in_young signature

[albertnetymk]

This PR consists of 2 commits:

1. The actual change of the signature.
2. Adding the missing override in changed files.

The second commit is auto generated using make CONF=debug compile-commands-hotspot; clang-tidy --fix -checks=modernize-use-override -p build/linux-x64-debug <file>.

Test: hotspot_gc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293023: Change CardTable::is_in_young signature

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10061/head:pull/10061
$ git checkout pull/10061

Update a local copy of the PR:
$ git checkout pull/10061
$ git pull https://git.openjdk.org/jdk pull/10061/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10061

View PR using the GUI difftool:
$ git pr show -t 10061

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10061.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (89407437)

[kimbarrett]

Change looks good.

Wearing my archeologist hat, I'd prefer the override part be in a separate change.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293023: Change CardTable::is_in_young signature

Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• bc5ffc8: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub
• 98ce45f: 8292981: Unify and restructure integer printing format specifiers
• 3ac91b0: 8293003: Review running time of Warn5 regression test
• e0168a0: 8288012: AArch64: unnecessary macro expansion in stubGenerator_aarch64
• 99c3ab0: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
• 0fb9469: 8290126: Add a check in JavadocTester for "javadoc should not crash"
• 0a4d0ce: 8293121: (fs) Refactor UnixFileSystem copying into generic Unix, Linux, and BSD implementations
• 032be16: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
• e393973: 8292990: Improve test coverage for XPath Axes: parent
• fa68371: 8292584: assert(cb != __null) failed: must be with -XX:-Inline
• ... and 60 more: https://git.openjdk.org/jdk/compare/b0e0b87891eb81c2b33c1cfa598701b7bd2e5bdf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit ce06a3b.
Since your change was applied there have been 72 commits pushed to the master branch:

• 26cac08: 8293209: Parallel: Remove unused variables in PSParallelCompact::invoke
• 46523b8: 8293219: Microsoft toolchain selection picks 32-bit tools over 64-bit
• bc5ffc8: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub
• 98ce45f: 8292981: Unify and restructure integer printing format specifiers
• 3ac91b0: 8293003: Review running time of Warn5 regression test
• e0168a0: 8288012: AArch64: unnecessary macro expansion in stubGenerator_aarch64
• 99c3ab0: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
• 0fb9469: 8290126: Add a check in JavadocTester for "javadoc should not crash"
• 0a4d0ce: 8293121: (fs) Refactor UnixFileSystem copying into generic Unix, Linux, and BSD implementations
• 032be16: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
• ... and 62 more: https://git.openjdk.org/jdk/compare/b0e0b87891eb81c2b33c1cfa598701b7bd2e5bdf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit ce06a3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.