-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag #10072
8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag #10072
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardly trivial as these macros are totally obscure to begin with :)
Where is the definition of what the arguments to ALL_FLAGS means? [Found it - allFlags.hpp]
It appears we have been handling develop and notproduct incorrectly.
Doesn't JVMFlagsEnum also need adjustment?
OK I removed the word "trivial" from the PR descroption.
Yes, |
There is an extra character at the end of that bug id which causes JBS to act very strangely. I'm not clear why these issues are being separated out. We seem to have a general problem (that we have know about for a couple of years - ref the discussion in JDK-8236736) that notproduct flags are handled incorrectly throughout, so why not fix everything together? |
I want to produce a simple fix for the crash issue, so that it could be backported if necessary. Fixing the visibility issue of notproduct is quite involved and may affect many files (which read notproduct flags in product code). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
Thanks.
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks @dholmes-ora and @coleenp for the review! |
Going to push as commit 1cf245d.
Your commit was automatically rebased without conflicts. |
The function
FLAG_MEMBER_SETTER(name)
is no longer declared for non-product flags (develop
ornotproduct
) in a product build. If you use useFLAG_SET_XXX
with such a flag in a product build, you'd get a C++ compile error.This is validated by the change in arguments.cpp, which used to set the
notproduct
flagUseDebuggerErgo1
in product builds. Now this code must be put inside#ifndef PRODUCT
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10072/head:pull/10072
$ git checkout pull/10072
Update a local copy of the PR:
$ git checkout pull/10072
$ git pull https://git.openjdk.org/jdk pull/10072/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10072
View PR using the GUI difftool:
$ git pr show -t 10072
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10072.diff