Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292008: Transition the JDK to the common standard of C11 #10077

Closed
wants to merge 4 commits into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Aug 30, 2022

This patch will set C11 as the "language level" for C code in the JDK code base, similar to how we set C++14 for the C++ code.

At this point, (almost) all our compilers support C11. The "almost" here is the one exception, Visual Studio 2017. I've chosen to keep VS2017 as an accepted compiler, and if that is used, we will still build without C11 as a language level. This is a suboptimal solution however, and I think we should start thinking about removing VS2017 as a supported compiler really soon.

For further background on the switch to C11, see JDK-8292008 and this mail.

I have tested this patch with Tier 1-3 in Oracle's internal CI system.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292008: Transition the JDK to the common standard of C11

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10077/head:pull/10077
$ git checkout pull/10077

Update a local copy of the PR:
$ git checkout pull/10077
$ git pull https://git.openjdk.org/jdk pull/10077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10077

View PR using the GUI difftool:
$ git pr show -t 10077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10077.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2022

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 30, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292008: Transition the JDK to the common standard of C11

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 6f29734: 8293178: Remove obsolete properties from javadoc resource file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 30, 2022
@magicus
Copy link
Member Author

magicus commented Aug 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

Going to push as commit 6076128.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 6f29734: 8293178: Remove obsolete properties from javadoc resource file

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2022
@openjdk openjdk bot closed this Aug 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@magicus Pushed as commit 6076128.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the use-c11 branch September 6, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants